fix: the last Table column is not calculated when the columns have a … #1564
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yvmunayev
approved these changes
May 20, 2020
TahimiLeonBravo
requested review from
TahimiLeonBravo
and removed request for
AlejandroYanes
TahimiLeonBravo
requested changes
May 21, 2020
| @@ -405,7 +405,7 @@ export default class Table extends Component { | |||
| }; | |||
| const maxRowSelection = this.getMaxRowSelection(); | |||
| const minColWidth = Number(minColumnWidth) || 50; | |||
| const maxColWidth = Number(maxColumnWidth) || 1000; | |||
| const maxColWidth = Number(maxColumnWidth) || 5000; | |||
There was a problem hiding this comment.
Let's use Infinity instead 5000
…en-the-columns-have-a-width-fixed
TahimiLeonBravo
approved these changes
May 21, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fix: #1552
Changes proposed in this PR:
the last Table column is not calculated when the columns have a width fixed
I have followed (at least) the PR section of the contributing guide.
@nexxtway/react-rainbow