feat: implement enumerate rows to table component

[ghost]

feat: implement enumerate rows to table component

[commit-lint]

Features

• implement enumerate rows to table component (0ec0122)
• specs added for enumerable column integration for Table component (0c4abed)

Bug Fixes

• improved extra columns append to columnsData (5bb4827)
• improved getColumns setup (f7bc1cb)
• updated to align with spec results (b60d228)
• counter updates and markup fix (fff845f)
• counter (038f638)
• firt data column (efe518c)

Contributors

@blakmetall, @LeandroTorresSicilia

[LeandroTorresSicilia]

If you inspect an example with selection you will see this:

it means that the first element in the row is a td tag with role="gridcell" (the column with the checkbox) and the second is a th tag with scope="row" (the first column with real content data)
In the case of the number column we should do the same
We should add unit test to this, to ensure that in the case where you use two columns before the data like using numbers and selection columns, then the third element in the row is which use the th tag and the scope="row" and the others are td elements with role="gridcell"

[ghost]

If you inspect an example with selection you will see this:

it means that the first element in the row is a td tag with role="gridcell" (the column with the checkbox) and the second is a th tag with scope="row" (the first column with real content data)
In the case of the number column we should do the same
We should add unit test to this, to ensure that in the case where you use two columns before the data like using numbers and selection columns, then the third element in the row is which use the th tag and the scope="row" and the others are td elements with role="gridcell"

...updating markup and adding test cases on this

[LeandroTorresSicilia]

@blakmetall why you close this pr?
we shouldn't close PRs unnecessarily

[ghost]

@blakmetall why you close this pr?
we shouldn't close PRs unnecessarily

by mistake I believe, I wanted to delete a comment

[ghost]

SPECS DEFINITIONS PROPOSAL

---

Table

• should not add a column when showCheckboxColumn and showRowNumberColumn are not passed (UPDATE)... previously: should not add a column when showCheckboxColumn is not passed
• should add a column when showRowNumberColumn is passed (NEW)
• should have the right value passed for enumerable column when showRowNumberColumn and rowNumberOffset are passed (NEW)
• should add two columns when showCheckboxColumn and showRowNumberColumn are passed (NEW)
• should update the columns state when add a column and (showCheckboxColumn and showRowNumberColumn) are not passed (UPDATE) ...previously:
  should update the columns state when add a column showCheckboxColumn is not passed
• should update the columns state when add a column and showRowNumberColumn is passed (NEW)

body/cell.js

<Cell /> when isFirst is not passed

• should render the enumerableCell component when columnType is "WITH_ENUMERABLE" (NEW)

<Cell /> when isFirst is is passed

• should render the SelectableCell component when columnType is "WITH_ENUMERABLE" (NEW)

body/row.js

• should set the right value to isFirst prop in the rendered Cell components when the first column contains the configurable checkbox selection column data (NEW)
• should set the right value to isFirst prop in the rendered Cell components when the first column contains the configurable enumerable column data (NEW)
• should set the right value to isFirst prop in the rendered Cell components when the first two columns contains the configurable enumerable and checkbox selection column data (NEW)

helpers/columns/getColumns.js

• should return null when children is null, showCheckboxColumn is false and showRowNumberColumn is false (UPDATE)
• should return an empty array when children is not passed, showCheckboxColumn is false
  and showRowNumberColumn is false (UPDATE)
• should return an empty array when children is an array with falsy values, showCheckboxColumn is false and showRowNumberColumn is false (UPDATE)
• should return an array with the columns props when showCheckboxColumn is false and showRowNumberColumn is false (UPDATE)
• should return an array with the columns props, plus the selectable column when showCheckboxColumn is true (UNCHANGED)
• should return an array with the columns props, plus the enumerable column data including enumerable offset value when showRowNumberColumn is true and rowNumberOffset is set (NEW)
  (the spec below was applied in the spec above)
  should return an array with the enumerable column containing the right rowNumberOffset value when showRowNumberColumn is true and rowNumberOffset is passed
• should return an array with the columns props, plus the enumerable and the selectable columns when showCheckboxColumn and showRowNumberColumn are true (NEW)
• should return an array with the right columns props when one column is type "action" (UNCHANGED)
• should return an array with the right columns props when defaultWidth and width are passed (UNCHANGED)
• should return an array with the right columns props when defaultWidth is passed and is out of range (UNCHANGED)

helpers/columns/getEnumerableWidth.js (NEW)

(moved as helper because it was needed to be mocked for a few specks)

• should return the default width when value is not sent
• should return the default calculated width when value is default
• should return the right width when value length is 3 (999)

---