fix: show empty message when no options #1615
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Bug Fixes
Contributors@LeandroTorresSicilia, @amontalvof, @TahimiLeonBravo Commit-Lint commandsYou can trigger Commit-Lint actions by commenting on this PR:
|
TahimiLeonBravo
approved these changes
Jun 8, 2020
| @@ -0,0 +1,29 @@ | |||
| import React from 'react'; | |||
There was a problem hiding this comment.
start filename with lowercase
| @@ -54,13 +56,15 @@ const InternalDropdown = forwardRef((props, reference) => { | |||
| const [activeOptionName, setActiveOptionName] = useState(null); | |||
| const [activeOptionIndex, setActiveOptionIndex] = useState(0); | |||
| const [activeChildrenMap, setActiveChildrenMap] = useState(); | |||
| const [emptyMessage, setEmptyMessage] = useState(''); | |||
There was a problem hiding this comment.
let's call this searchValue:
const [searchValue, setSearchValue] = useState('');
| > | ||
| <Content isLoading={isLoading}> | ||
| <Provider value={context}>{children}</Provider> | ||
| </Content> | ||
| </Ul> | ||
| <RenderIf isTrue={showEmptyMessage}> | ||
| <EmptyMessage emptyMessage={emptyMessage} /> |
There was a problem hiding this comment.
same here, also change the prop to searchValue
| export const MessageHighLight = attachThemeAttrs(styled.p)` | ||
| font-size: 16px; | ||
| font-weight: 900; | ||
| color: ${props => props.palette.text.main}; |
There was a problem hiding this comment.
use 4 space for indentation
…nexxtway/react-rainbow into internal-dropdown-empty-message
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fix: #1609
Changes proposed in this PR:
I have followed (at least) the PR section of the contributing guide.
@nexxtway/react-rainbow