Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: remove undesired outline from table components headers #1660

Merged
merged 1 commit into from
Jun 27, 2020

Conversation

ernesto-tapia
Copy link
Contributor

Fix: #1167

Changes proposed in this PR:

-Added outline:none in Table/head/styled/th.js .focus line 22, to prevent unexpected outlines in Safari.

@nexxtway/react-rainbow

@commit-lint
Copy link

commit-lint bot commented Jun 26, 2020

Bug Fixes

  • remove undesired outline from table components headers (07100fa)

Contributors

@ernesto-tapia

Commit-Lint commands

You can trigger Commit-Lint actions by commenting on this PR:

  • @Commit-Lint merge patch will merge dependabot PR on "patch" versions (X.X.Y - Y change)
  • @Commit-Lint merge minor will merge dependabot PR on "minor" versions (X.Y.Y - Y change)
  • @Commit-Lint merge major will merge dependabot PR on "major" versions (Y.Y.Y - Y change)
  • @Commit-Lint merge disable will desactivate merge dependabot PR
  • @Commit-Lint review will approve dependabot PR
  • @Commit-Lint stop review will stop approve dependabot PR

@CLAassistant
Copy link

CLAassistant commented Jun 26, 2020

CLA assistant check
All committers have signed the CLA.

@ernesto-tapia ernesto-tapia changed the title Remove undesired outline from table components headers fix: Remove undesired outline from table components headers Jun 26, 2020
@ernesto-tapia ernesto-tapia changed the title fix: Remove undesired outline from table components headers fix: remove undesired outline from table components headers Jun 26, 2020
@TahimiLeonBravo TahimiLeonBravo merged commit 4de9acc into nexxtway:master Jun 27, 2020
@TahimiLeonBravo
Copy link
Collaborator

Good job!!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

fix: unexpected focus styles of the Table in Safari
3 participants