Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: format the PhoneInput when copy and paste #1661

Merged
merged 3 commits into from
Jun 27, 2020
Merged

fix: format the PhoneInput when copy and paste #1661

merged 3 commits into from
Jun 27, 2020

Conversation

Ricardo-HE
Copy link
Contributor

fix: #1651

Changes proposed in this PR:

@nexxtway/react-rainbow

* fix: format the PhoneInput when copy and paste

* fix: Digits only as imputs on PhoneInput
@commit-lint
Copy link

commit-lint bot commented Jun 27, 2020

Bug Fixes

  • format the PhoneInput when copy and paste (938307b)

Contributors

@RicardoHE97

Commit-Lint commands

You can trigger Commit-Lint actions by commenting on this PR:

  • @Commit-Lint merge patch will merge dependabot PR on "patch" versions (X.X.Y - Y change)
  • @Commit-Lint merge minor will merge dependabot PR on "minor" versions (X.Y.Y - Y change)
  • @Commit-Lint merge major will merge dependabot PR on "major" versions (Y.Y.Y - Y change)
  • @Commit-Lint merge disable will desactivate merge dependabot PR
  • @Commit-Lint review will approve dependabot PR
  • @Commit-Lint stop review will stop approve dependabot PR

@CLAassistant
Copy link

CLAassistant commented Jun 27, 2020

CLA assistant check
All committers have signed the CLA.

@Ricardo-HE
Copy link
Contributor Author

One integration test failed on something I believe I didn't touch. I might be wrong but I don't know for sure.
The fail test says:
should_change_to_the_previous_month_when_is_in_the_first_day_of_a_month_and_press_LEFT_OR_UP_arrow_keys - chrome.Calendar
Was something I did that produced this?

@TahimiLeonBravo
Copy link
Collaborator

TahimiLeonBravo commented Jun 27, 2020

One integration test failed on something I believe I didn't touch. I might be wrong but I don't know for sure.
The fail test says:
should_change_to_the_previous_month_when_is_in_the_first_day_of_a_month_and_press_LEFT_OR_UP_arrow_keys - chrome.Calendar
Was something I did that produced this?

@RicardoHE97 that's an integration test that is fragile and sometimes fails. I made re-run to it and then it passed

@TahimiLeonBravo
Copy link
Collaborator

Hi @RicardoHE97, Good Job!!
In order to merge the pr is needed to sign the CLA
https://cla-assistant.io/nexxtway/react-rainbow?pullRequest=1661

@TahimiLeonBravo TahimiLeonBravo merged commit 1c0c6af into nexxtway:master Jun 27, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

fix: format the PhoneInput when copy and paste
4 participants