Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: added example whit columns rendered dynamically on the Table co… #1665

Merged

Conversation

amontalvof
Copy link
Collaborator

@amontalvof amontalvof commented Jun 28, 2020

fix: #1646

Changes proposed in this PR:

@nexxtway/react-rainbow

@commit-lint
Copy link

commit-lint bot commented Jun 28, 2020

Documentation

  • added example whit columns rendered dynamically on the Table component (6b6c2a1)

Bug Fixes

  • deleted uppercase on dinamically table example (387dcfe)
  • removed ; on example Table component (cb3c28c)
  • put new example to last (9fffe36)

Contributors

@amontalvof, @LeandroTorresSicilia

Commit-Lint commands

You can trigger Commit-Lint actions by commenting on this PR:

  • @Commit-Lint merge patch will merge dependabot PR on "patch" versions (X.X.Y - Y change)
  • @Commit-Lint merge minor will merge dependabot PR on "minor" versions (X.Y.Y - Y change)
  • @Commit-Lint merge major will merge dependabot PR on "major" versions (Y.Y.Y - Y change)
  • @Commit-Lint merge disable will desactivate merge dependabot PR
  • @Commit-Lint review will approve dependabot PR
  • @Commit-Lint stop review will stop approve dependabot PR

@LeandroTorresSicilia LeandroTorresSicilia linked an issue Jun 28, 2020 that may be closed by this pull request
12 tasks
@@ -693,7 +775,7 @@ const StatusBadge = ({ value }) => <Badge label={value} variant="lightest" style
<Column header="Company" field="company" />
<Column header="Email" field="email" />
</Table>
</div>
</div>;

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

remove these semicolons

@LeandroTorresSicilia
Copy link
Member

@amontalvof Good job!

@LeandroTorresSicilia LeandroTorresSicilia merged commit a518cf0 into master Jun 29, 2020
@LeandroTorresSicilia LeandroTorresSicilia deleted the columns-rendered-dynamically-Table-component branch June 29, 2020 05:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

docs: add one example whit columns rendered dynamically on the Table component
2 participants