Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: modal focus to work when opening from picklist #1682

Merged
merged 6 commits into from
Jul 7, 2020

Conversation

hportales2000
Copy link
Contributor

@hportales2000 hportales2000 commented Jul 3, 2020

fix: #1678

Changes proposed in this PR:

@nexxtway/react-rainbow

@commit-lint
Copy link

commit-lint bot commented Jul 3, 2020

Bug Fixes

  • modal focus to work when opening from picklist (5c8d798)
  • reverting changes to only have Picklist onChange function included in setTimeOut (ebe89c4)
  • cleanning code (2b8ccf5)

Contributors

@TahimiLeonBravo, @LeandroTorresSicilia

Commit-Lint commands

You can trigger Commit-Lint actions by commenting on this PR:

  • @Commit-Lint merge patch will merge dependabot PR on "patch" versions (X.X.Y - Y change)
  • @Commit-Lint merge minor will merge dependabot PR on "minor" versions (X.Y.Y - Y change)
  • @Commit-Lint merge major will merge dependabot PR on "major" versions (Y.Y.Y - Y change)
  • @Commit-Lint merge disable will desactivate merge dependabot PR
  • @Commit-Lint review will approve dependabot PR
  • @Commit-Lint stop review will stop approve dependabot PR

@CLAassistant
Copy link

CLAassistant commented Jul 3, 2020

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you all sign our Contributor License Agreement before we can accept your contribution.
2 out of 3 committers have signed the CLA.

✅ LeandroTorresSicilia
✅ TahimiLeonBravo
❌ Pablo Alberto Hernandez Portales


Pablo Alberto Hernandez Portales seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account.
You have signed the CLA already but the status is still pending? Let us recheck it.

Copy link
Contributor

@yvmunayev yvmunayev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@LeandroTorresSicilia LeandroTorresSicilia merged commit 0406210 into master Jul 7, 2020
@LeandroTorresSicilia LeandroTorresSicilia deleted the fix-modal-focus branch July 7, 2020 04:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

fix: when open a modal from a picklist the focus get in the picklist and never come to the modal​
5 participants