fix: styles in the Picklist component when the prop readOnly is passed #1684
Conversation
Bug Fixes
ContributorsCommit-Lint commandsYou can trigger Commit-Lint actions by commenting on this PR:
|
| @@ -43,6 +43,7 @@ const PickerInput = attachThemeAttrs(styled(StyledInput))` | |||
| box-shadow: none; | |||
| background-color: transparent; | |||
| border: 2px solid transparent; | |||
| pointer-events: none; | |||
There was a problem hiding this comment.
The problem with this solution is that it changes the course to the hand that indicates some action and the course should be the text
src/components/Input/label/index.js
Outdated
| @@ -29,6 +29,7 @@ Label.propTypes = { | |||
| required: PropTypes.bool, | |||
| inputId: PropTypes.string, | |||
| readOnly: PropTypes.bool, | |||
| disabled: PropTypes.bool, | |||
There was a problem hiding this comment.
To change the API of a component a previous discussion is necessary, this small change has a big impact, you had to change 5 component which in turn many more components depends on them for this reason it is not feasible. I think the best solution would be to add to the RenderIf where the Label is painted the conditions of disabled and readOnly
we have a bug when use the keyboard navigation, you can review the bug on the video here |
|
@rgah2107 the label should be centered on the Picklist component when |
…hub.com/rgah2107/react-rainbow into picklist-component-styles-when-readOnly
|
Code Climate has analyzed commit 58146c0 and detected 0 issues on this pull request. View more on Code Climate. |
fix: #1683
Changes proposed in this PR:
styles in the Picklist component when the prop readOnly is passed
I have followed (at least) the PR section of the contributing guide.
@nexxtway/react-rainbow