test: add unit tests to MarkdownOutput component
#1690
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
TestsContributorsCommit-Lint commandsYou can trigger Commit-Lint actions by commenting on this PR:
|
maxxgreene
reviewed
Jul 11, 2020
maxxgreene
reviewed
Jul 11, 2020
src/components/MarkdownOutput/hooks/__test__/useMarkdownToReact.spec.js
Outdated
Show resolved
Hide resolved
![codeclimate[bot]](https://avatars.githubusercontent.com/in/9403?s=60&v=4){kind=small}
| /<h5 class="(.*)">This is a level 5 header<\/h5>/, | ||
| /<h6 class="(.*)">This is a level 6 header<\/h6>/, | ||
| ]; | ||
| values.forEach((value, index) => { |
There was a problem hiding this comment.
Identical blocks of code found in 4 locations. Consider refactoring.
| /<ol class="(.*)">\n<li class="(.*)">Item #1<\/li>\n<li class="(.*)">Item #2<\/li>\n<li class="(.*)">Item #3<\/li>\n<\/ol>/, | ||
| /<ul class="(.*)">\n<li class="(.*)"><input type="checkbox" checked="" disabled=""\/>(.*)Item #1<\/li>\n<li class="(.*)"><input type="checkbox" disabled=""\/>(.*)Item #2<\/li>\n<li class="(.*)"><input type="checkbox" disabled=""\/>(.*)Item #3<\/li>\n<\/ul>/, | ||
| ]; | ||
| values.forEach((value, index) => { |
There was a problem hiding this comment.
Identical blocks of code found in 4 locations. Consider refactoring.
| /<pre[^>]*><code[^>]*>([^<]*)<\/code><\/pre>/, | ||
| /<code\s[^>]*>doSomenthing<\/code>/, | ||
| ]; | ||
| values.forEach((value, index) => { |
There was a problem hiding this comment.
Identical blocks of code found in 4 locations. Consider refactoring.
| /<table[^>]*><thead[^>]*><tr[^>]*><td style="text-align:right"[^>]*>Header<\/td><\/tr><\/thead><tbody[^>]*><tr[^>]*><td style="text-align:right"[^>]*>Cell<\/td><\/tr><\/tbody><\/table>/, | ||
| /<table[^>]*><thead[^>]*><tr[^>]*><td style="text-align:center"[^>]*>Header<\/td><\/tr><\/thead><tbody[^>]*><tr[^>]*><td style="text-align:center"[^>]*>Cell<\/td><\/tr><\/tbody><\/table>/, | ||
| ]; | ||
| values.forEach((value, index) => { |
There was a problem hiding this comment.
Identical blocks of code found in 4 locations. Consider refactoring.
| expect(ReactDOMServer.renderToString(result.current)).toMatch(patterns[index]); | ||
| }); | ||
| }); | ||
| it('should return valid html for paragraphs', () => { |
There was a problem hiding this comment.
Similar blocks of code found in 2 locations. Consider refactoring.
LeandroTorresSicilia
approved these changes
Jul 12, 2020
| expect(ReactDOMServer.renderToString(result.current)).toMatch(patterns[index]); | ||
| }); | ||
| }); | ||
| it('should return valid html for links', () => { |
There was a problem hiding this comment.
Similar blocks of code found in 2 locations. Consider refactoring.
|
Code Climate has analyzed commit 0b4006e and detected 6 issues on this pull request. Here's the issue category breakdown:
View more on Code Climate. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fix: #1641
Changes proposed in this PR:
add unit tests to
MarkdownOutputcomponentI have followed (at least) the PR section of the contributing guide.
@nexxtway/react-rainbow