Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: responsive calendar #1691

Merged
merged 9 commits into from
Jul 10, 2020
Merged

fix: responsive calendar #1691

merged 9 commits into from
Jul 10, 2020

Conversation

hportales2000
Copy link
Contributor

@hportales2000 hportales2000 commented Jul 7, 2020 •
edited
Loading

fix: # 1680

Changes proposed in this PR:

@nexxtway/react-rainbow

@commit-lint
Copy link

commit-lint bot commented Jul 7, 2020 •
edited
Loading

Bug Fixes

Contributors

@hportales2000, @TahimiLeonBravo

Commit-Lint commands

You can trigger Commit-Lint actions by commenting on this PR:

  • @Commit-Lint merge patch will merge dependabot PR on "patch" versions (X.X.Y - Y change)
  • @Commit-Lint merge minor will merge dependabot PR on "minor" versions (X.Y.Y - Y change)
  • @Commit-Lint merge major will merge dependabot PR on "major" versions (Y.Y.Y - Y change)
  • @Commit-Lint merge disable will desactivate merge dependabot PR
  • @Commit-Lint review will approve dependabot PR
  • @Commit-Lint stop review will stop approve dependabot PR

@CLAassistant
Copy link

CLAassistant commented Jul 7, 2020 •
edited
Loading

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you all sign our Contributor License Agreement before we can accept your contribution.
1 out of 2 committers have signed the CLA.

✅ hportales2000
❌ Pablo Alberto Hernandez Portales

Pablo Alberto Hernandez Portales seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account.
You have signed the CLA already but the status is still pending? Let us recheck it.

@hportales2000 hportales2000 changed the title Fix calendar mobile fix: responsive calendar Jul 7, 2020
@TahimiLeonBravo
Copy link
Collaborator

LGTM +1 @LeandroTorresSicilia @hportales2000 we have one test failing here

@TahimiLeonBravo
Copy link
Collaborator

LGTM +1 @LeandroTorresSicilia @hportales2000 we have one test failing here

For now, we should skip this test as we have to implement a new keyboard navigation behavior in the component.

yvmunayev
yvmunayev reviewed Jul 10, 2020
View reviewed changes
Copy link
Contributor

@yvmunayev yvmunayev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

check useMarkdownToReact 2.js this is code from another PR. Probably when you did merge you had conflicts and they were not resolved well.

@TahimiLeonBravo TahimiLeonBravo merged commit 50b79ed into master Jul 10, 2020
@TahimiLeonBravo TahimiLeonBravo deleted the fix-calendar-mobile branch July 10, 2020 20:40
@TahimiLeonBravo TahimiLeonBravo linked an issue Jul 16, 2020 that may be closed by this pull request
fix: Calendar on mobile screen and double variant is passed #1680
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yvmunayev yvmunayev yvmunayev left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

fix: Calendar on mobile screen and double variant is passed
4 participants
@hportales2000 @CLAassistant @TahimiLeonBravo @yvmunayev