Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

style: add animation to the breadcrumb component #1705

Merged
merged 6 commits into from
Jul 21, 2020

Conversation

amontalvof
Copy link
Collaborator

fix: #1702

Changes proposed in this PR:

@nexxtway/react-rainbow

@commit-lint
Copy link

commit-lint bot commented Jul 11, 2020

Styles

  • add animation to the breadcrumb component (618758e)
  • animation added to the breadcrumbs component (e9dc55e)
  • fixed animation to the breadcrumb component (bbfa69d)
  • fixed animation to the anchors in breadcrumb component (52f4a3c)
  • fixed animation to the breadcrumb component on firefox browser (236a404)
  • added focus color on the breadcrumb component (3fa8846)

Contributors

@amontalvof

Commit-Lint commands

You can trigger Commit-Lint actions by commenting on this PR:

  • @Commit-Lint merge patch will merge dependabot PR on "patch" versions (X.X.Y - Y change)
  • @Commit-Lint merge minor will merge dependabot PR on "minor" versions (X.Y.Y - Y change)
  • @Commit-Lint merge major will merge dependabot PR on "major" versions (Y.Y.Y - Y change)
  • @Commit-Lint merge disable will desactivate merge dependabot PR
  • @Commit-Lint review will approve dependabot PR
  • @Commit-Lint stop review will stop approve dependabot PR

@TahimiLeonBravo
Copy link
Collaborator

@amontalvof the breadcrumb element flick when is selected, it should be animated like the video

@codeclimate
Copy link

codeclimate bot commented Jul 21, 2020

Code Climate has analyzed commit 3fa8846 and detected 2 issues on this pull request.

Here's the issue category breakdown:

Category Count
Duplication 2

View more on Code Climate.

@TahimiLeonBravo TahimiLeonBravo merged commit 937d28c into master Jul 21, 2020
@TahimiLeonBravo TahimiLeonBravo deleted the animation-to-the-breadcrumb-component branch July 21, 2020 23:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

styles: add animation and improve accesibility to the Breadcrumb component
2 participants