Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: style rounded the chart bars #1711

Merged
merged 3 commits into from
Jul 12, 2020
Merged

feat: style rounded the chart bars #1711

merged 3 commits into from
Jul 12, 2020

Conversation

maxxgreene
Copy link
Contributor

Changes proposed in this PR:

@nexxtway/react-rainbow

@commit-lint
Copy link

commit-lint bot commented Jul 12, 2020 •
edited
Loading

Features

  • style rounded the chart bars (2fd8dd1)

Bug Fixes

Code Refactoring

Contributors

@maxxgreene

Commit-Lint commands

You can trigger Commit-Lint actions by commenting on this PR:

  • @Commit-Lint merge patch will merge dependabot PR on "patch" versions (X.X.Y - Y change)
  • @Commit-Lint merge minor will merge dependabot PR on "minor" versions (X.Y.Y - Y change)
  • @Commit-Lint merge major will merge dependabot PR on "major" versions (Y.Y.Y - Y change)
  • @Commit-Lint merge disable will desactivate merge dependabot PR
  • @Commit-Lint review will approve dependabot PR
  • @Commit-Lint stop review will stop approve dependabot PR

@maxxgreene maxxgreene linked an issue Jul 12, 2020 that may be closed by this pull request
feat: add border round to the bar chart #1710
Closed
@maxxgreene maxxgreene added the WIP work in progress label Jul 12, 2020
codeclimate[bot]
codeclimate bot reviewed Jul 12, 2020
View reviewed changes
src/components/Chart/chart.js Outdated
return maxRadius;
};

Chart.elements.Rectangle.prototype.draw = function Draw() {
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Function Draw has 32 lines of code (exceeds 25 allowed). Consider refactoring.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done!

@codeclimate
Copy link

codeclimate bot commented Jul 12, 2020

Code Climate has analyzed commit a86075b and detected 0 issues on this pull request.

View more on Code Climate.

@maxxgreene maxxgreene removed the WIP work in progress label Jul 12, 2020
@maxxgreene maxxgreene merged commit f5034ba into master Jul 12, 2020
@maxxgreene maxxgreene deleted the chart-rounded branch July 12, 2020 07:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@codeclimate codeclimate[bot] codeclimate left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

feat: add border round to the bar chart
1 participant
@maxxgreene