fix: option component accept number on name prop #1712
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Bug Fixes
Tests
ContributorsCommit-Lint commandsYou can trigger Commit-Lint actions by commenting on this PR:
|
TahimiLeonBravo
requested changes
Jul 13, 2020
| className="rainbow-p-bottom_xx-large rainbow-m-bottom_xx-large" | ||
| > | ||
| <div className="rainbow-flex rainbow-align_right"> | ||
| <Picklist |
There was a problem hiding this comment.
@yvmunayev I think we should use one of the existing examples instead add one new
|
Code Climate has analyzed commit 8c76b40 and detected 1 issue on this pull request. Here's the issue category breakdown:
View more on Code Climate. |
LeandroTorresSicilia
approved these changes
Jul 20, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fix: #1692
Changes proposed in this PR:
fix: option component accept number on name prop
I have followed (at least) the PR section of the contributing guide.
@nexxtway/react-rainbow