feat: add success, error and warning variants to the Chip compo…
#1717
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Features
Bug Fixes
ContributorsCommit-Lint commandsYou can trigger Commit-Lint actions by commenting on this PR:
|
![codeclimate[bot]](https://avatars.githubusercontent.com/in/9403?s=60&v=4){kind=small}
| @@ -42,6 +42,27 @@ const StyledContainer = attachThemeAttrs(styled.span)` | |||
| border: 1px solid ${props.palette.brand.main}; | |||
| color: ${props.palette.getContrastText(props.palette.brand.main)}; | |||
| `}; | |||
| ${props => | |||
There was a problem hiding this comment.
Similar blocks of code found in 4 locations. Consider refactoring.
| border: 1px solid ${props.palette.success.main}; | ||
| color: ${props.palette.getContrastText(props.palette.success.main)}; | ||
| `}; | ||
| ${props => |
There was a problem hiding this comment.
Similar blocks of code found in 4 locations. Consider refactoring.
| border: 1px solid ${props.palette.warning.main}; | ||
| color: ${props.palette.getContrastText(props.palette.warning.main)}; | ||
| `}; | ||
| ${props => |
There was a problem hiding this comment.
Similar blocks of code found in 4 locations. Consider refactoring.
|
@rgah2107 we should make the close button have the same color of the text (just like the brand variant)
|
|
@rgah2107 I think we should add the new variants to the examples |
|
Code Climate has analyzed commit 317c5b1 and detected 0 issues on this pull request. View more on Code Climate. |
| props.variant === 'brand' && | ||
| `fill: ${props.palette.getContrastText(props.palette.brand.main)};`}; | ||
| variants.includes(props.variant) && | ||
| `fill: ${props.palette.getContrastText(props.palette[props.variant].main)};`}; |
LeandroTorresSicilia
approved these changes
Jul 15, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fix: #1713
Changes proposed in this PR:
add
success,errorandwarningvariants to the Chip componentI have followed (at least) the PR section of the contributing guide.
@nexxtway/react-rainbow