Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: reset the selection on the Calendar when clicking in a day inside the selected range #1721

Merged
merged 3 commits into from
Jul 17, 2020

Conversation

wildergd
Copy link
Collaborator

fix: #1716

Changes proposed in this PR:

@nexxtway/react-rainbow

@commit-lint
Copy link

commit-lint bot commented Jul 16, 2020

Bug Fixes

  • fix selection reset when click inside selected range (4930774)
  • fix selection reset (b9cca80)

Contributors

@wildergd

Commit-Lint commands

You can trigger Commit-Lint actions by commenting on this PR:

  • @Commit-Lint merge patch will merge dependabot PR on "patch" versions (X.X.Y - Y change)
  • @Commit-Lint merge minor will merge dependabot PR on "minor" versions (X.Y.Y - Y change)
  • @Commit-Lint merge major will merge dependabot PR on "major" versions (Y.Y.Y - Y change)
  • @Commit-Lint merge disable will desactivate merge dependabot PR
  • @Commit-Lint review will approve dependabot PR
  • @Commit-Lint stop review will stop approve dependabot PR

@TahimiLeonBravo
Copy link
Collaborator

@wildergd I see the issue with the selected range was fixed, but now we have another issue

Steps to repro

  1. Go to https://react-rainbow.io/#!/Calendar/5
  2. Click on "30"
  3. Click on "12"

Current Behavior

The two days are selected "30" and "12"

Expected Behavior

The "30" day should not be selected

@codeclimate
Copy link

codeclimate bot commented Jul 17, 2020

Code Climate has analyzed commit a829944 and detected 0 issues on this pull request.

View more on Code Climate.

Copy link
Collaborator

@TahimiLeonBravo TahimiLeonBravo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@LeandroTorresSicilia LeandroTorresSicilia merged commit 04e252d into master Jul 17, 2020
@LeandroTorresSicilia LeandroTorresSicilia deleted the fix-calendar-range-selection-reset branch July 17, 2020 03:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

fix: reset the selection on the Calendar when clicking in a day inside the selected range
3 participants