feat: adding new badge variants and examples #1744
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
FeaturesContributors@hportales2000, @TahimiLeonBravo Commit-Lint commandsYou can trigger Commit-Lint actions by commenting on this PR:
|
![codeclimate[bot]](https://avatars.githubusercontent.com/in/9403?s=60&v=4){kind=small}
| @@ -50,6 +50,24 @@ const StyledContainer = attchThemeAttrs(styled.span).attrs(props => { | |||
| color: ${props.palette.getContrastText(props.inverse)}; | |||
| background-color: ${props.inverse}; | |||
| `}; | |||
| ${props => | |||
There was a problem hiding this comment.
Similar blocks of code found in 4 locations. Consider refactoring.
| color: ${props.palette.getContrastText(props.palette.warning.main)}; | ||
| background-color: ${props.palette.warning.main}; | ||
| `}; | ||
| ${props => |
There was a problem hiding this comment.
Similar blocks of code found in 4 locations. Consider refactoring.
| color: ${props.palette.getContrastText(props.palette.success.main)}; | ||
| background-color: ${props.palette.success.main}; | ||
| `}; | ||
| ${props => |
There was a problem hiding this comment.
Similar blocks of code found in 4 locations. Consider refactoring.
TahimiLeonBravo
commented
Jul 23, 2020
src/components/Badge/readme.md
Outdated
| className="rainbow-m-around_medium" | ||
| label="Signal Badge" | ||
| title="the badge title" | ||
| style={{'color': 'white', 'backgroundColor': 'forestgreen', 'boxShadow': 'inset 0 0 0 1px'}} |
There was a problem hiding this comment.
we should not add the styles inline instead create a const
src/components/Badge/readme.md
Outdated
| className="rainbow-m-around_medium" | ||
| label="Floating Badge" | ||
| title="the badge title" | ||
| style={{'color': 'white', 'backgroundColor': 'lightsalmon', 'borderColor': 'darksalmon', 'boxShadow': 'gray 0 6px 16px -6px'}} |
src/components/Badge/readme.md
Outdated
| className="rainbow-m-around_medium" | ||
| label="Desert Badge" | ||
| title="the badge title" | ||
| style={{'color': 'peru', 'backgroundColor': 'bisque',}} |
yvmunayev
reviewed
Jul 23, 2020
Comment on lines
+39
to
+41
| 'warning', | ||
| 'success', | ||
| 'error', |
There was a problem hiding this comment.
You need to add this props in the declarations file (index.d.ts)
yvmunayev
approved these changes
Jul 23, 2020
LeandroTorresSicilia
approved these changes
Jul 24, 2020
|
Code Climate has analyzed commit 299437f and detected 4 issues on this pull request. Here's the issue category breakdown:
View more on Code Climate. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fix: #1741
Changes proposed in this PR:
add new variants to the Badge
add custom badge examples
I have followed (at least) the PR section of the contributing guide.
@nexxtway/react-rainbow