Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add support multi-language to MarkdownOutput component #1755

Conversation

yvmunayev
Copy link
Contributor

@yvmunayev yvmunayev commented Jul 25, 2020

#1743

Changes proposed in this PR:

@nexxtway/react-rainbow

@commit-lint
Copy link

commit-lint bot commented Jul 25, 2020

Features

  • add support multi-language to MarkdownOutput component (84defce)
  • add java languaje example (ff88135)

Documentation

Chore

  • change restore_cache key (51336cb)

Bug Fixes

  • change rehype-highlight config and add import minify from rehype-minify-whitespace; (0a254b8)

Contributors

@yvmunayev, @TahimiLeonBravo

Commit-Lint commands

You can trigger Commit-Lint actions by commenting on this PR:

  • @Commit-Lint merge patch will merge dependabot PR on "patch" versions (X.X.Y - Y change)
  • @Commit-Lint merge minor will merge dependabot PR on "minor" versions (X.Y.Y - Y change)
  • @Commit-Lint merge major will merge dependabot PR on "major" versions (Y.Y.Y - Y change)
  • @Commit-Lint merge disable will desactivate merge dependabot PR
  • @Commit-Lint review will approve dependabot PR
  • @Commit-Lint stop review will stop approve dependabot PR

@TahimiLeonBravo
Copy link
Collaborator

TahimiLeonBravo commented Jul 26, 2020

@yvmunayev we should represent the styles of the code depending on the language defined by the user.

  • when the user doesn't define any language all the code should look like with the same color
  • when the user defines a language we should detect the language and represent the code with the styles of the language added

if we make that, it should look like this:
Screen Shot 2020-07-26 at 1 39 23 PM

now our implementation looks like this:
Screen Shot 2020-07-26 at 1 47 29 PM

@codeclimate
Copy link

codeclimate bot commented Jul 27, 2020

Code Climate has analyzed commit 4aa6086 and detected 0 issues on this pull request.

View more on Code Climate.

@TahimiLeonBravo TahimiLeonBravo linked an issue Jul 28, 2020 that may be closed by this pull request
@LeandroTorresSicilia LeandroTorresSicilia merged commit 17e4431 into nexxtway:master Jul 28, 2020
@yvmunayev yvmunayev deleted the add-support-multi-language-markdown-output branch September 29, 2020 20:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

feat: add support multi-language to MarkdownOutput component
3 participants