Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: fixing children limitation on renderif component using ract frag… #1759

Merged
merged 1 commit into from
Jul 27, 2020

Conversation

rolandin
Copy link
Collaborator

@rolandin rolandin commented Jul 26, 2020

  • Wrapped children with react fragments.

  • Now the developer doesn't need to wrap the multiple children inside fragments every time RenderIf is used

fix: #1758

Changes proposed in this PR:

@nexxtway/react-rainbow

@commit-lint
Copy link

commit-lint bot commented Jul 26, 2020

Bug Fixes

  • fixing children limitation on renderif component using ract fragments (047a36a)

Contributors

@rolandin

Commit-Lint commands

You can trigger Commit-Lint actions by commenting on this PR:

  • @Commit-Lint merge patch will merge dependabot PR on "patch" versions (X.X.Y - Y change)
  • @Commit-Lint merge minor will merge dependabot PR on "minor" versions (X.Y.Y - Y change)
  • @Commit-Lint merge major will merge dependabot PR on "major" versions (Y.Y.Y - Y change)
  • @Commit-Lint merge disable will desactivate merge dependabot PR
  • @Commit-Lint review will approve dependabot PR
  • @Commit-Lint stop review will stop approve dependabot PR

@codeclimate
Copy link

codeclimate bot commented Jul 26, 2020

Code Climate has analyzed commit 047a36a and detected 0 issues on this pull request.

View more on Code Climate.

@LeandroTorresSicilia LeandroTorresSicilia merged commit 120c0e4 into master Jul 27, 2020
@LeandroTorresSicilia LeandroTorresSicilia deleted the fix-renderif-children-limitation branch July 27, 2020 02:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

fix: allow passing multiple children to the RenderIf component
2 participants