Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: implement listview variant to the table #1773

Merged

Conversation

yvmunayev
Copy link
Contributor

fix: #1513

Changes proposed in this PR:

@nexxtway/react-rainbow

@commit-lint
Copy link

commit-lint bot commented Jul 31, 2020

Features

  • implement new variant to table component (71324ad)
  • add style with listview variant (08a47a8)

Bug Fixes

Contributors

@yvmunayev, @TahimiLeonBravo

Commit-Lint commands

You can trigger Commit-Lint actions by commenting on this PR:

  • @Commit-Lint merge patch will merge dependabot PR on "patch" versions (X.X.Y - Y change)
  • @Commit-Lint merge minor will merge dependabot PR on "minor" versions (X.Y.Y - Y change)
  • @Commit-Lint merge major will merge dependabot PR on "major" versions (Y.Y.Y - Y change)
  • @Commit-Lint merge disable will desactivate merge dependabot PR
  • @Commit-Lint review will approve dependabot PR
  • @Commit-Lint stop review will stop approve dependabot PR

src/components/Table/body/cell.js Outdated Show resolved Hide resolved
padding: 0;
text-align: left;
box-sizing: border-box;

${props =>
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Similar blocks of code found in 3 locations. Consider refactoring.

src/components/Table/body/styled/cell.js Show resolved Hide resolved
src/components/Table/body/cell.js Outdated Show resolved Hide resolved
library/exampleComponents/Icons/coin.js Show resolved Hide resolved
@TahimiLeonBravo
Copy link
Collaborator

@yvmunayev review the styles when howRowNumberColumn is passed
Screen Shot 2020-07-31 at 1 02 03 PM

@TahimiLeonBravo
Copy link
Collaborator

@yvmunayev let's add a new example with showCheckboxColumn and showRowNumberColumn

@TahimiLeonBravo
Copy link
Collaborator

TahimiLeonBravo commented Aug 7, 2020

@yvmunayev

  • remove the background-color and right rectangle on the header when hovering
  • remove the background-color and border-color right rectangle on the header when the focus

Screen Shot 2020-08-06 at 9 26 22 PM

Screen Shot 2020-08-06 at 9 26 17 PM

@TahimiLeonBravo
Copy link
Collaborator

@yvmunayev fix the blue border when focus
Screen Shot 2020-08-06 at 9 26 32 PM

@TahimiLeonBravo
Copy link
Collaborator

TahimiLeonBravo commented Aug 10, 2020

@yvmunayev review the UI when showCheckboxColumn and showRowNumberColumn, it should look like the last example design
https://zpl.io/blPO9Kz


const StyledCheckboxWrapper = attachThemeAttrs(styled(StyledWrapper))`
const StyledCheckboxWrapper = styled.div`
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Similar blocks of code found in 2 locations. Consider refactoring.

@LeandroTorresSicilia
Copy link
Member

@yvmunayev Remember to update the index.d.ts

@codeclimate
Copy link

codeclimate bot commented Aug 23, 2020

Code Climate has analyzed commit 98fcfa9 and detected 10 issues on this pull request.

Here's the issue category breakdown:

Category Count
Complexity 1
Duplication 9

View more on Code Climate.

@TahimiLeonBravo TahimiLeonBravo merged commit 46c6c6c into nexxtway:master Aug 25, 2020
@yvmunayev yvmunayev deleted the implement-new-variant-to-the-table branch September 29, 2020 20:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

feat: implement new variant to the Table component
3 participants