-
-
Notifications
You must be signed in to change notification settings - Fork 113
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: implement listview variant to the table #1773
feat: implement listview variant to the table #1773
Conversation
FeaturesBug Fixes
ContributorsCommit-Lint commandsYou can trigger Commit-Lint actions by commenting on this PR:
|
padding: 0; | ||
text-align: left; | ||
box-sizing: border-box; | ||
|
||
${props => |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Similar blocks of code found in 3 locations. Consider refactoring.
@yvmunayev review the styles when |
@yvmunayev let's add a new example with |
|
@yvmunayev fix the blue border when focus |
…ayev/react-rainbow into implement-new-variant-to-the-table
@yvmunayev review the UI when showCheckboxColumn and showRowNumberColumn, it should look like the last example design |
|
||
const StyledCheckboxWrapper = attachThemeAttrs(styled(StyledWrapper))` | ||
const StyledCheckboxWrapper = styled.div` |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Similar blocks of code found in 2 locations. Consider refactoring.
@yvmunayev Remember to update the index.d.ts |
Code Climate has analyzed commit 98fcfa9 and detected 10 issues on this pull request. Here's the issue category breakdown:
View more on Code Climate. |
fix: #1513
Changes proposed in this PR:
feat: implement listview variant to the table
I have followed (at least) the PR section of the contributing guide.
@nexxtway/react-rainbow