Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

styles: add animation to Rating component #1774

Merged

Conversation

lyon93
Copy link
Contributor

@lyon93 lyon93 commented Jul 31, 2020

fix: #1772

Changes proposed in this PR:

@nexxtway/react-rainbow

@commit-lint
Copy link

commit-lint bot commented Jul 31, 2020

Styles

  • add animation to Rating component (cde00c0)

Bug Fixes

  • change behavior animation when is Rating readOnly (25bc3b5)
  • indentation issues (cf62e3d)

Contributors

@lyon93, @TahimiLeonBravo

Commit-Lint commands

You can trigger Commit-Lint actions by commenting on this PR:

  • @Commit-Lint merge patch will merge dependabot PR on "patch" versions (X.X.Y - Y change)
  • @Commit-Lint merge minor will merge dependabot PR on "minor" versions (X.Y.Y - Y change)
  • @Commit-Lint merge major will merge dependabot PR on "major" versions (Y.Y.Y - Y change)
  • @Commit-Lint merge disable will desactivate merge dependabot PR
  • @Commit-Lint review will approve dependabot PR
  • @Commit-Lint stop review will stop approve dependabot PR

@TahimiLeonBravo
Copy link
Collaborator

@lyon93 we shouldn't animate the stars when the component is "readOnly", review the behavior on the "Rating readOnly" example

@codeclimate
Copy link

codeclimate bot commented Aug 5, 2020

Code Climate has analyzed commit 88c36c2 and detected 0 issues on this pull request.

View more on Code Climate.

@TahimiLeonBravo TahimiLeonBravo merged commit 5b6b857 into nexxtway:master Aug 5, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

styles: add animation to Rating component
2 participants