feat: add prop variant to the Input Component #1776
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Features
Bug Fixes
ContributorsCommit-Lint commandsYou can trigger Commit-Lint actions by commenting on this PR:
|
|
@lyon93 remove the shadow when readOnly is passed remove the shadow when disabled is passed |
| @@ -127,6 +127,9 @@ Input.propTypes = { | |||
| className: PropTypes.string, | |||
| /** An object with custom style applied to the outer element. */ | |||
| style: PropTypes.object, | |||
| /** The variant changes the appearance of the Input. Accepted variants include default, | |||
| * and shaded. This value defaults to default. */ | |||
| variant: PropTypes.oneOf(['default', 'shaded']), | |||
There was a problem hiding this comment.
we need to add variant prop to src/components/Input/index.d.ts file, in order to bring typescript support
TahimiLeonBravo
approved these changes
Aug 10, 2020
|
Code Climate has analyzed commit 3f50399 and detected 0 issues on this pull request. View more on Code Climate. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fix: #1775
Changes proposed in this PR:
I have followed (at least) the PR section of the contributing guide.
@nexxtway/react-rainbow