-
-
Notifications
You must be signed in to change notification settings - Fork 112
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add header prop to the textarea component #1807
Conversation
Features
Contributors@amontalvof, @TahimiLeonBravo, @LeandroTorresSicilia Commit-Lint commandsYou can trigger Commit-Lint actions by commenting on this PR:
|
src/components/Textarea/readme.md
Outdated
|
||
function TextareaExample(props) { | ||
const [count, setCount] = useState(0); | ||
const maxLength = props.maxLength; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
here you can use destructuring:
const { maxLength } = props;
src/components/Textarea/readme.md
Outdated
<StyledHeader> | ||
<Chip | ||
onDelete={() => alert('Delete Chip!')} | ||
style={{width:'100%'}} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
to be consistent with the example don't use styles inline, instead use a styled component
…nexxtway/react-rainbow into add-header-prop-to-the-textarea
Code Climate has analyzed commit 1d47ab4 and detected 2 issues on this pull request. Here's the issue category breakdown:
View more on Code Climate. |
fix: #1799
Changes proposed in this PR:
I have followed (at least) the PR section of the contributing guide.
@nexxtway/react-rainbow