feat: implement hideTableHeader prop in table component #1818
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Features
ContributorsCommit-Lint commandsYou can trigger Commit-Lint actions by commenting on this PR:
|
|
Analysis results are not available for those commits View more on Code Climate. |
|
@lyon93 check here there are conflicts |
|
@lyon93 please check the conflicts that you have, need be resolved |
reiniergs
reviewed
Sep 16, 2020
| const component = mount(<Head columns={columns} />); | ||
| const header = component.find('Header'); | ||
| expect(header.at(0).prop('hideTableHeader')).toBeFalsy(); | ||
| }); |
There was a problem hiding this comment.
these tests ^^ should check the header is not visible, checking the prop value when is being passed is testing React :) .. not the component behavior.
Although, the implementation of the feature looks good to me
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fix: #1793
Changes proposed in this PR:
I have followed (at least) the PR section of the contributing guide.
@nexxtway/react-rainbow