refactor: labelAlignment prop on all inputable components #1869
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![codeclimate[bot]](https://avatars.githubusercontent.com/in/9403?s=60&v=4){kind=small}
yvmunayev
approved these changes
Sep 29, 2020
TahimiLeonBravo
requested changes
Oct 3, 2020
src/components/Slider/index.js
Outdated
| hideLabel={hideLabel} | ||
| labelAlignment={labelAlignment} | ||
| inputId={this.sliderId} | ||
| /> |
There was a problem hiding this comment.
on the Slider component the label must be aligned to the edges, it should not have padding
Code Refactoring
Bug Fixes
Contributors@rgah2107, @LeandroTorresSicilia Commit-Lint commandsYou can trigger Commit-Lint actions by commenting on this PR:
|
TahimiLeonBravo
approved these changes
Oct 3, 2020
| left: 'flex-start', | ||
| center: 'center', | ||
| right: 'flex-end', | ||
| }; | ||
|
|
||
| const StyledLabel = attachThemeAttrs(styled.label)` |
There was a problem hiding this comment.
why no reuse the input label here?
LeandroTorresSicilia
approved these changes
Oct 4, 2020
| @@ -30,6 +31,18 @@ describe('<Slider />', () => { | |||
| const component = mount(<Slider disabled />); | |||
| expect(component.find('input').prop('disabled')).toBe(true); | |||
| }); | |||
| it('should set "left" to labelAlignment prop passed in the Label component', () => { | |||
There was a problem hiding this comment.
Similar blocks of code found in 2 locations. Consider refactoring.
| const component = mount(<Slider label="Slider Label" labelAlignment="left" />); | ||
| expect(component.find(StyledLabel).prop('labelAlignment')).toBe('left'); | ||
| }); | ||
| it('should set "right" to labelAlignment prop passed in the Label component', () => { |
There was a problem hiding this comment.
Similar blocks of code found in 2 locations. Consider refactoring.
| const component = mount(<Slider label="Slider Label" labelAlignment="right" />); | ||
| expect(component.find(StyledLabel).prop('labelAlignment')).toBe('right'); | ||
| }); | ||
| it('should set "center" to labelAlignment if prop not passed in the Label component', () => { |
There was a problem hiding this comment.
Similar blocks of code found in 2 locations. Consider refactoring.
|
Code Climate has analyzed commit 9d3b83b and detected 25 issues on this pull request. Here's the issue category breakdown:
View more on Code Climate. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fix: #1865
Changes proposed in this PR:
add labelAlignment prop to the Label component
refactor labelAlignment prop on all inputable components
add labelAlignment prop on all inputable components that don't have it
I have followed (at least) the PR section of the contributing guide.
@nexxtway/react-rainbow