Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: isLoading on the Table component when the variant is listView #1896

Merged
merged 9 commits into from
Oct 14, 2020
Merged

fix: isLoading on the Table component when the variant is listView #1896

merged 9 commits into from
Oct 14, 2020

Conversation

wildergd
Copy link
Collaborator

@wildergd wildergd commented Oct 9, 2020 •
edited
Loading

fix: #1893

Changes proposed in this PR:

@nexxtway/react-rainbow

@commit-lint
Copy link

commit-lint bot commented Oct 9, 2020 •
edited
Loading

Styles

  • fix style for elementLoading sub-component (cb4e842)
  • fix table loading styles when variant is listview (95e48d2)

Bug Fixes

  • fix amount of loading indicators in Table component (0eb7134)

Contributors

@wildergd, @TahimiLeonBravo

Commit-Lint commands

You can trigger Commit-Lint actions by commenting on this PR:

  • @Commit-Lint merge patch will merge dependabot PR on "patch" versions (X.X.Y - Y change)
  • @Commit-Lint merge minor will merge dependabot PR on "minor" versions (X.Y.Y - Y change)
  • @Commit-Lint merge major will merge dependabot PR on "major" versions (Y.Y.Y - Y change)
  • @Commit-Lint merge disable will desactivate merge dependabot PR
  • @Commit-Lint review will approve dependabot PR
  • @Commit-Lint stop review will stop approve dependabot PR

@wildergd wildergd changed the title fix: isLoading on the Table component when the variant is listView fix: isLoading on the Table component when the variant is listView Oct 9, 2020
TahimiLeonBravo
TahimiLeonBravo reviewed Oct 12, 2020
View reviewed changes
Copy link
Collaborator

@TahimiLeonBravo TahimiLeonBravo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1

@codeclimate
Copy link

codeclimate bot commented Oct 14, 2020

Code Climate has analyzed commit 0b4abcc and detected 2 issues on this pull request.

Here's the issue category breakdown:

Category Count
Duplication 2

View more on Code Climate.

@LeandroTorresSicilia LeandroTorresSicilia merged commit 0902637 into master Oct 14, 2020
@LeandroTorresSicilia LeandroTorresSicilia deleted the fix-table-isloading branch October 14, 2020 18:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@codeclimate codeclimate[bot] codeclimate left review comments

@LeandroTorresSicilia LeandroTorresSicilia LeandroTorresSicilia approved these changes

@TahimiLeonBravo TahimiLeonBravo TahimiLeonBravo approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

fix: isLoading on the Table component when the variant is listView
3 participants
@wildergd @LeandroTorresSicilia @TahimiLeonBravo