feat: add variant prop on the Tabset component #1899
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Features
Bug Fixes
Contributors@rgah2107, @LeandroTorresSicilia Commit-Lint commandsYou can trigger Commit-Lint actions by commenting on this PR:
|
![codeclimate[bot]](https://avatars.githubusercontent.com/in/9403?s=60&v=4){kind=small}
|
Code Climate has analyzed commit a26a624 and detected 4 issues on this pull request. Here's the issue category breakdown:
View more on Code Climate. |
| box-sizing: border-box; | ||
| } | ||
| ${props => | ||
| (props.variant === 'card' || !variants.includes(props.variant)) && |
There was a problem hiding this comment.
there is not much implication since there are only two elements in the array but here you can use a map instead, thus avoiding the iteration
LeandroTorresSicilia
approved these changes
Oct 12, 2020
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fix: #1880
Changes proposed in this PR:
add variant prop
add tests
add a new interactive example
I have followed (at least) the PR section of the contributing guide.
@nexxtway/react-rainbow