-
-
Notifications
You must be signed in to change notification settings - Fork 114
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: implement inline edit on table #1933
Conversation
Features
Contributors@amontalvof, @TahimiLeonBravo, @LeandroTorresSicilia Commit-Lint commandsYou can trigger Commit-Lint actions by commenting on this PR:
|
there is a lint error |
}); | ||
|
||
it('should render an input with the received value when click inside the EditableCell', () => { | ||
const component = mount( |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Identical blocks of code found in 6 locations. Consider refactoring.
}); | ||
|
||
it('should clear the input when click in button clear', () => { | ||
const component = mount( |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Identical blocks of code found in 6 locations. Consider refactoring.
@@ -1446,4 +1469,166 @@ describe('<Table />', () => { | |||
} | |||
}); | |||
}); | |||
|
|||
it('should return a table with EditableCell', () => { | |||
const component = mount( |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Identical blocks of code found in 6 locations. Consider refactoring.
}); | ||
|
||
it('should render a span with the received value of the data inside the EditableCell', () => { | ||
const component = mount( |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Identical blocks of code found in 6 locations. Consider refactoring.
}); | ||
|
||
it('should unmount the input when blur', () => { | ||
const component = mount( |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Identical blocks of code found in 6 locations. Consider refactoring.
Code Climate has analyzed commit 571b00d and detected 37 issues on this pull request. Here's the issue category breakdown:
View more on Code Climate. |
fix: #502
Changes proposed in this PR:
I have followed (at least) the PR section of the contributing guide.
@nexxtway/react-rainbow