Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: added variant shaded to select component #1952

Merged
merged 2 commits into from
Oct 28, 2020

Conversation

amontalvof
Copy link
Collaborator

fix: #1949

Changes proposed in this PR:

@nexxtway/react-rainbow

@commit-lint
Copy link

commit-lint bot commented Oct 27, 2020

Features

  • added variant shaded to select component (18e0f84)

Bug Fixes

Contributors

@amontalvof, @TahimiLeonBravo

Commit-Lint commands

You can trigger Commit-Lint actions by commenting on this PR:

  • @Commit-Lint merge patch will merge dependabot PR on "patch" versions (X.X.Y - Y change)
  • @Commit-Lint merge minor will merge dependabot PR on "minor" versions (X.Y.Y - Y change)
  • @Commit-Lint merge major will merge dependabot PR on "major" versions (Y.Y.Y - Y change)
  • @Commit-Lint merge disable will desactivate merge dependabot PR
  • @Commit-Lint review will approve dependabot PR
  • @Commit-Lint stop review will stop approve dependabot PR

@codeclimate
Copy link

codeclimate bot commented Oct 27, 2020

Code Climate has analyzed commit aa9e9f2 and detected 3 issues on this pull request.

Here's the issue category breakdown:

Category Count
Duplication 3

View more on Code Climate.

@TahimiLeonBravo TahimiLeonBravo merged commit 8d14c17 into master Oct 28, 2020
@TahimiLeonBravo TahimiLeonBravo deleted the implement-shaded-variant-select-component branch October 28, 2020 04:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

feat: add the variant shaded to the Select component
2 participants