Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Picklist when loading and after render options #1961

Merged
merged 10 commits into from
Nov 14, 2020
Merged

fix: Picklist when loading and after render options #1961

merged 10 commits into from
Nov 14, 2020

Conversation

wildergd
Copy link
Collaborator

@wildergd wildergd commented Oct 30, 2020 •
edited
Loading

fix: #1958

Changes proposed in this PR:

@nexxtway/react-rainbow

@commit-lint
Copy link

commit-lint bot commented Oct 30, 2020 •
edited
Loading

Bug Fixes

  • fix bug in picklist when it is open and updated (c18fbc1)
  • fix issues in comments (2111957)

Tests

  • fix tests for Up default resolvers (1a4ad81)

Contributors

@wildergd, @LeandroTorresSicilia

Commit-Lint commands

You can trigger Commit-Lint actions by commenting on this PR:

  • @Commit-Lint merge patch will merge dependabot PR on "patch" versions (X.X.Y - Y change)
  • @Commit-Lint merge minor will merge dependabot PR on "minor" versions (X.Y.Y - Y change)
  • @Commit-Lint merge major will merge dependabot PR on "major" versions (Y.Y.Y - Y change)
  • @Commit-Lint merge disable will desactivate merge dependabot PR
  • @Commit-Lint review will approve dependabot PR
  • @Commit-Lint stop review will stop approve dependabot PR

@wildergd wildergd changed the title fix: Picklist when loading and after render options. fix: Picklist when loading and after render options. Oct 30, 2020
@wildergd wildergd changed the title fix: Picklist when loading and after render options. fix: picklist component when loading and after render options. Oct 30, 2020
@wildergd wildergd changed the title fix: picklist component when loading and after render options. fix: Picklist when loading and after render options. Oct 30, 2020
@wildergd wildergd changed the title fix: Picklist when loading and after render options. fix: Picklist when loading and after render options Oct 30, 2020
@wildergd wildergd force-pushed the fix-picklist-position-when-loading branch from be8a284 to 2111957 Compare November 9, 2020 15:28
@codeclimate
Copy link

codeclimate bot commented Nov 14, 2020

Code Climate has analyzed commit ec61897 and detected 0 issues on this pull request.

View more on Code Climate.

@LeandroTorresSicilia LeandroTorresSicilia merged commit 9598472 into master Nov 14, 2020
@LeandroTorresSicilia LeandroTorresSicilia deleted the fix-picklist-position-when-loading branch November 14, 2020 16:05
jpetaux pushed a commit to jpetaux/react-rainbow that referenced this pull request Jun 27, 2021
@wildergd @LeandroTorresSicilia @jpetaux
fix: Picklist when loading and after render options (nexxtway#1961)
783cf2b 
* fix: fix bug in picklist when it is open and updated

* fix: fix issues in comments

* test: fix tests for Up default resolvers

Co-authored-by: Jose Leandro Torres <jtorressicilia@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@LeandroTorresSicilia LeandroTorresSicilia LeandroTorresSicilia approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

fix: Picklist when loading and after render options.
2 participants
@wildergd @LeandroTorresSicilia