Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: implement shaded and bare variants on Lookup component #1981

Conversation

gtallesb
Copy link
Collaborator

@gtallesb gtallesb commented Nov 6, 2020

fix: #1979

Changes proposed in this PR:

-add new prop variant on Lookup.js component
-add propTypes and defaultProps for variant

@nexxtway/react-rainbow

@commit-lint
Copy link

commit-lint bot commented Nov 6, 2020

Features

  • implement shaded and bare variants on Lookup component (ca053aa)
  • add examples for shaded and bare variants (e4d5ed2)

Bug Fixes

Contributors

@gtallesb, @TahimiLeonBravo

Commit-Lint commands

You can trigger Commit-Lint actions by commenting on this PR:

  • @Commit-Lint merge patch will merge dependabot PR on "patch" versions (X.X.Y - Y change)
  • @Commit-Lint merge minor will merge dependabot PR on "minor" versions (X.Y.Y - Y change)
  • @Commit-Lint merge major will merge dependabot PR on "major" versions (Y.Y.Y - Y change)
  • @Commit-Lint merge disable will desactivate merge dependabot PR
  • @Commit-Lint review will approve dependabot PR
  • @Commit-Lint stop review will stop approve dependabot PR

@codeclimate
Copy link

codeclimate bot commented Nov 7, 2020

Code Climate has analyzed commit 1aab7bf and detected 1 issue on this pull request.

Here's the issue category breakdown:

Category Count
Duplication 1

View more on Code Climate.

@TahimiLeonBravo TahimiLeonBravo merged commit 4cf5725 into master Nov 7, 2020
@TahimiLeonBravo TahimiLeonBravo deleted the feat-implement-shaded-and-bare-variants-on-Lookup-component branch November 7, 2020 15:59
jpetaux pushed a commit to jpetaux/react-rainbow that referenced this pull request Jun 27, 2021
…y#1981)

* feat: implement shaded and bare variants on Lookup component

* feat: add examples for shaded and bare variants

* fix: example

Co-authored-by: Tahimi <tahimileon@gmail.com>
Co-authored-by: TahimiLeonBravo <tahimi@nexxtway.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

feat: implement shaded and bare variant on Lookup component
2 participants