fix: picklist close unexpected when clicking on the search #1987
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…to fix-picklist-close-on-search-click
Bug Fixes
Contributors@HellWolf93, @LeandroTorresSicilia Commit-Lint commandsYou can trigger Commit-Lint actions by commenting on this PR:
|
HellWolf93
changed the title
LeandroTorresSicilia
approved these changes
Nov 22, 2020
|
Code Climate has analyzed commit 601bfca and detected 0 issues on this pull request. View more on Code Climate. |
jpetaux
pushed a commit
to jpetaux/react-rainbow
that referenced
this pull request
Jun 27, 2021
…1987) * fix: Picklist close unexpected when clicking on the search fix: nexxtway#1978 * fix: lint error on Pagination component * fix: remove unnecessary re-render * fix: remove stopImmediatePropagation usage Co-authored-by: Jose Leandro Torres <jtorressicilia@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fix: #1978
Changes proposed in this PR:
Fix unexpected close on Picklist when clicking the search input
Add test case to this specific issue
Fix minor lint error on Pagination
I have followed (at least) the PR section of the contributing guide.
@nexxtway/react-rainbow