Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add prop keepScrollEnabled on InternalOverlay #1999

Merged
merged 2 commits into from
Nov 14, 2020

Conversation

maxxgreene
Copy link
Contributor

@maxxgreene maxxgreene commented Nov 14, 2020

#1826
fix: #2000

Changes proposed in this PR:

@nexxtway/react-rainbow

@commit-lint
Copy link

commit-lint bot commented Nov 14, 2020

Features

  • add prop keepScrollEnabled on InternalOverlay (6f4996d)

Contributors

@maxxgreene, @LeandroTorresSicilia

Commit-Lint commands

You can trigger Commit-Lint actions by commenting on this PR:

  • @Commit-Lint merge patch will merge dependabot PR on "patch" versions (X.X.Y - Y change)
  • @Commit-Lint merge minor will merge dependabot PR on "minor" versions (X.Y.Y - Y change)
  • @Commit-Lint merge major will merge dependabot PR on "major" versions (Y.Y.Y - Y change)
  • @Commit-Lint merge disable will desactivate merge dependabot PR
  • @Commit-Lint review will approve dependabot PR
  • @Commit-Lint stop review will stop approve dependabot PR

@codeclimate
Copy link

codeclimate bot commented Nov 14, 2020

Code Climate has analyzed commit 34ae6b7 and detected 0 issues on this pull request.

View more on Code Climate.

@LeandroTorresSicilia LeandroTorresSicilia merged commit 0cec768 into master Nov 14, 2020
@LeandroTorresSicilia LeandroTorresSicilia deleted the keepScrollEnabled branch November 14, 2020 18:23
jpetaux pushed a commit to jpetaux/react-rainbow that referenced this pull request Jun 27, 2021
Co-authored-by: Jose Leandro Torres <jtorressicilia@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

feat: add keepScrollEnabled prop on the InternalOverlay component
2 participants