Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: implement Path and PathStep components #2028

Merged

Conversation

wildergd
Copy link
Collaborator

@wildergd wildergd commented Nov 26, 2020

fix: #2004

Changes proposed in this PR:

@nexxtway/react-rainbow

@commit-lint
Copy link

commit-lint bot commented Nov 26, 2020

Features

  • add Path and PathStep components (578b71b)

Bug Fixes

Tests

  • add unit tests for helper functions (dec271d)

Documentation

Contributors

wildergd, TahimiLeonBravo

Commit-Lint commands

You can trigger Commit-Lint actions by commenting on this PR:

  • @Commit-Lint merge patch will merge dependabot PR on "patch" versions (X.X.Y - Y change)
  • @Commit-Lint merge minor will merge dependabot PR on "minor" versions (X.Y.Y - Y change)
  • @Commit-Lint merge major will merge dependabot PR on "major" versions (Y.Y.Y - Y change)
  • @Commit-Lint merge disable will desactivate merge dependabot PR
  • @Commit-Lint review will approve dependabot PR
  • @Commit-Lint stop review will stop approve dependabot PR

src/components/Path/styled/index.js Outdated Show resolved Hide resolved
src/components/Path/styled/index.js Outdated Show resolved Hide resolved
src/components/Path/icons/checkMark.js Outdated Show resolved Hide resolved
src/components/Path/icons/exclamation.js Outdated Show resolved Hide resolved
src/components/Path/index.js Outdated Show resolved Hide resolved
src/components/PathStep/styled/index.js Show resolved Hide resolved
src/components/Path/index.js Show resolved Hide resolved
src/components/PathStep/index.js Show resolved Hide resolved
src/components/PathStep/styled/index.js Show resolved Hide resolved
src/components/PathStep/icons/exclamation.js Show resolved Hide resolved
Copy link
Contributor

@yvmunayev yvmunayev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@TahimiLeonBravo I think that when hovering in the steps the global size of the component should not change.

src/components/Path/index.js Outdated Show resolved Hide resolved
@wildergd
Copy link
Collaborator Author

@TahimiLeonBravo I think that when hovering in the steps the global size of the component should not change.

ok fixed

@wildergd wildergd force-pushed the feat-implement-path-and-pathstep-components branch from 04de7e3 to ea126c1 Compare December 2, 2020 13:42
@codeclimate
Copy link

codeclimate bot commented Dec 2, 2020

Code Climate has analyzed commit ea126c1 and detected 10 issues on this pull request.

Here's the issue category breakdown:

Category Count
Complexity 5
Duplication 5

View more on Code Climate.

@LeandroTorresSicilia LeandroTorresSicilia merged commit 3d12cea into master Dec 4, 2020
@LeandroTorresSicilia LeandroTorresSicilia deleted the feat-implement-path-and-pathstep-components branch December 4, 2020 15:49
jpetaux pushed a commit to jpetaux/react-rainbow that referenced this pull request Jun 27, 2021
* feat: add Path and PathStep components

* fix: some improvements on code

* fix: fix props descriptions

* fix: fix some minor issues

* test: add unit tests for helper functions

* fix: refactor code

* docs: fix documentation

* fix: fix index.d.ts in Path component

* fix: issues in PR comments

* fix: issues in PR comments

* fix: some styles

* fix: lint issues

Co-authored-by: TahimiLeonBravo <tahimi@nexxtway.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

feat: implement Path and PathStep component
3 participants