feat: add variant and tooltip to ProgressIndicator #2030
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Features
Bug Fixes
Documentation
ContributorsHellWolf93, LeandroTorresSicilia, TahimiLeonBravo Commit-Lint commandsYou can trigger Commit-Lint actions by commenting on this PR:
|
![codeclimate[bot]](https://avatars.githubusercontent.com/in/9403?s=60&v=4){kind=small}
HellWolf93
changed the title
variant prop on the ProgressIndicator component and tooltip on the ProgressStep component
HellWolf93
force-pushed
the
implement-progressindicator-tooltip
branch
from
331ec73
to
fb4647d
Compare
yvmunayev
reviewed
Nov 30, 2020
src/components/ProgressIndicator/__test__/progressIndicator.spec.js
Outdated
Show resolved
Hide resolved
LeandroTorresSicilia
approved these changes
Dec 1, 2020
|
Code Climate has analyzed commit e0d40bf and detected 6 issues on this pull request. Here's the issue category breakdown:
View more on Code Climate. |
jpetaux
pushed a commit
to jpetaux/react-rainbow
that referenced
this pull request
Jun 27, 2021
* feat: add variant and tooltip to ProgressIndicator fix: nexxtway#1881 * fix: improve numeric variant * fix: fix numeric step styles to match default step * fix: use functional components for new examples * fix: improve ProgressIndicator tests * docs: remove unnecessary section Co-authored-by: Jose Leandro Torres <jtorressicilia@gmail.com> Co-authored-by: Tahimi <tahimileon@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fix: #1881
Changes proposed in this PR:
Add variant prop to ProgressIndicator
Add tooltip prop to ProgressStep
Test the ProgressStep component
I have followed (at least) the PR section of the contributing guide.