fix: picklist when readonly and click the label it opens the menu #2041
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Bug Fixes
Tests
ContributorsCommit-Lint commandsYou can trigger Commit-Lint actions by commenting on this PR:
|
LeandroTorresSicilia
approved these changes
Dec 7, 2020
| this.setState({ | ||
| isOpen: true, | ||
| }); | ||
| } |
There was a problem hiding this comment.
we should add test to this
![codeclimate[bot]](https://avatars.githubusercontent.com/in/9403?s=60&v=4){kind=small}
| @@ -132,4 +132,18 @@ describe('<Picklist />', () => { | |||
| expect(component.find('[aria-expanded=true]').exists()).toBe(false); | |||
| expect(component.find(InternalOverlay).prop('isVisible')).toBe(false); | |||
| }); | |||
| it('should not open menu when is readOnly and click the picklist label', () => { | |||
| const component = mount( | |||
There was a problem hiding this comment.
Similar blocks of code found in 3 locations. Consider refactoring.
TahimiLeonBravo
approved these changes
Dec 7, 2020
|
Code Climate has analyzed commit 8d14a83 and detected 1 issue on this pull request. Here's the issue category breakdown:
View more on Code Climate. |
LeandroTorresSicilia
approved these changes
Dec 7, 2020
jpetaux
pushed a commit
to jpetaux/react-rainbow
that referenced
this pull request
Jun 27, 2021
…xxtway#2041) * fix: picklist when readOnly and click the label it opens the menu * test: add unit test Co-authored-by: Tahimi <tahimileon@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fix: #2036
Changes proposed in this PR:
fix: picklist when readOnly and click the label it opens the menu
I have followed (at least) the PR section of the contributing guide.
@nexxtway/react-rainbow