Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: add tests for Path and PathStep components #2043

Merged
merged 12 commits into from
Dec 13, 2020

Conversation

wildergd
Copy link
Collaborator

@wildergd wildergd commented Dec 6, 2020

fix: #2004

Changes proposed in this PR:

@nexxtway/react-rainbow

@commit-lint
Copy link

commit-lint bot commented Dec 6, 2020

Bug Fixes

  • path and pathstep issues in behaviour (fc4b95e)
  • fix behaviour and styles for error and selected (0d20e66)
  • add some modifications to styles and docs (9d4d7e2)
  • color when hasError (510d1ba)
  • examples (97133ac)

Tests

Styles

  • fix browser focus and active borders (e8ece8c)

Documentation

Features

Contributors

wildergd, TahimiLeonBravo

Commit-Lint commands

You can trigger Commit-Lint actions by commenting on this PR:

  • @Commit-Lint merge patch will merge dependabot PR on "patch" versions (X.X.Y - Y change)
  • @Commit-Lint merge minor will merge dependabot PR on "minor" versions (X.Y.Y - Y change)
  • @Commit-Lint merge major will merge dependabot PR on "major" versions (Y.Y.Y - Y change)
  • @Commit-Lint merge disable will desactivate merge dependabot PR
  • @Commit-Lint review will approve dependabot PR
  • @Commit-Lint stop review will stop approve dependabot PR

@codeclimate
Copy link

codeclimate bot commented Dec 12, 2020

Code Climate has analyzed commit 97133ac and detected 4 issues on this pull request.

Here's the issue category breakdown:

Category Count
Duplication 4

View more on Code Climate.

@TahimiLeonBravo TahimiLeonBravo merged commit 4dac2f2 into master Dec 13, 2020
@TahimiLeonBravo TahimiLeonBravo deleted the test-path-pathstep-components branch December 13, 2020 14:51
jpetaux pushed a commit to jpetaux/react-rainbow that referenced this pull request Jun 27, 2021
* fix: path and pathstep issues in behaviour

* test: fix helpers tests

* fix: fix behaviour and styles for error and selected

* style: fix browser focus and active borders

* fix: add some modifications to styles and docs

* docs: fix documentation

* fix: color when hasError

* feat: add svg icons

* fix: examples

Co-authored-by: TahimiLeonBravo <tahimi@nexxtway.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

feat: implement Path and PathStep component
3 participants