-
-
Notifications
You must be signed in to change notification settings - Fork 113
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
test: add tests for Path
and PathStep
components
#2043
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Bug Fixes
Tests
Styles
Documentation
Features
ContributorsCommit-Lint commandsYou can trigger Commit-Lint actions by commenting on this PR:
|
yvmunayev
reviewed
Dec 8, 2020
Code Climate has analyzed commit 97133ac and detected 4 issues on this pull request. Here's the issue category breakdown:
View more on Code Climate. |
jpetaux
pushed a commit
to jpetaux/react-rainbow
that referenced
this pull request
Jun 27, 2021
* fix: path and pathstep issues in behaviour * test: fix helpers tests * fix: fix behaviour and styles for error and selected * style: fix browser focus and active borders * fix: add some modifications to styles and docs * docs: fix documentation * fix: color when hasError * feat: add svg icons * fix: examples Co-authored-by: TahimiLeonBravo <tahimi@nexxtway.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fix: #2004
Changes proposed in this PR:
fix some behaviour issues
add tests for
Path
andPathStep
componentsI have followed (at least) the PR section of the contributing guide.
@nexxtway/react-rainbow