feat: implement "tooltip" prop on the ButtonIcon component
#2064
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Features
Bug Fixes
Code Refactoring
ContributorsHellWolf93, LeandroTorresSicilia Commit-Lint commandsYou can trigger Commit-Lint actions by commenting on this PR:
|
![codeclimate[bot]](https://avatars.githubusercontent.com/in/9403?s=60&v=4){kind=small}
LeandroTorresSicilia
approved these changes
Dec 29, 2020
| super(props); | ||
| this.buttonRef = React.createRef(); | ||
| } | ||
| const ButtonIcon = React.forwardRef((props, ref) => { |
There was a problem hiding this comment.
Function ButtonIcon has 113 lines of code (exceeds 25 allowed). Consider refactoring.
|
Code Climate has analyzed commit 3ed3801 and detected 3 issues on this pull request. Here's the issue category breakdown:
View more on Code Climate. |
LeandroTorresSicilia
approved these changes
Dec 30, 2020
jpetaux
pushed a commit
to jpetaux/react-rainbow
that referenced
this pull request
Jun 27, 2021
…y#2064) * feat: implement "tooltip" prop on the `ButtonIcon` component fix: nexxtway#2059 * fix: solve errors on tests * refactor: make ButtonIcon a functional component * fix: fix error when using htmlElementRef * fix: fix tooltip behavior in ButtonIcon component * fix: add `buttonRef` to ButtonIcon API for backward compatibility Co-authored-by: Jose Leandro Torres <jtorressicilia@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fix: #2059
Changes proposed in this PR: