feat: add bare variant on the Picklist component #2065
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Features
Bug FixesContributorsrgah2107, LeandroTorresSicilia Commit-Lint commandsYou can trigger Commit-Lint actions by commenting on this PR:
|
TahimiLeonBravo
requested changes
Dec 26, 2020
![codeclimate[bot]](https://avatars.githubusercontent.com/in/9403?s=60&v=4){kind=small}
| @@ -36,7 +36,14 @@ const PickerInput = attachThemeAttrs(styled(StyledInput))` | |||
| box-shadow: none; | |||
| `} | |||
| `} | |||
|
|
|||
| ${props => | |||
There was a problem hiding this comment.
Similar blocks of code found in 2 locations. Consider refactoring.
|
Code Climate has analyzed commit e49d9d4 and detected 2 issues on this pull request. Here's the issue category breakdown:
View more on Code Climate. |
TahimiLeonBravo
approved these changes
Dec 27, 2020
LeandroTorresSicilia
approved these changes
Dec 27, 2020
jpetaux
pushed a commit
to jpetaux/react-rainbow
that referenced
this pull request
Jun 27, 2021
* feat: add bare variant on the Picklist component fix: nexxtway#2062 * fix: improve example * fix: add background color when hover Co-authored-by: Jose Leandro Torres <jtorressicilia@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fix: #2062
Changes proposed in this PR:
add bare variant on the Picklist component
add new example on the Picklist component
fix indentation problems in Input component
I have followed (at least) the PR section of the contributing guide.
@nexxtway/react-rainbow