Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: recalculate InternalOverlay position when content changes #2090

Merged

Conversation

HellWolf93
Copy link
Collaborator

fix: #2060

Changes proposed in this PR:

  • Update InternalOverlay position when the content changes

@commit-lint
Copy link

commit-lint bot commented Jan 11, 2021

Bug Fixes

  • recalculate InternalOverlay position when content changes (3d7cf51)

Contributors

HellWolf93

Commit-Lint commands

You can trigger Commit-Lint actions by commenting on this PR:

  • @Commit-Lint merge patch will merge dependabot PR on "patch" versions (X.X.Y - Y change)
  • @Commit-Lint merge minor will merge dependabot PR on "minor" versions (X.Y.Y - Y change)
  • @Commit-Lint merge major will merge dependabot PR on "major" versions (Y.Y.Y - Y change)
  • @Commit-Lint merge disable will desactivate merge dependabot PR
  • @Commit-Lint review will approve dependabot PR
  • @Commit-Lint stop review will stop approve dependabot PR

@codeclimate
Copy link

codeclimate bot commented Jan 11, 2021

Code Climate has analyzed commit 3d7cf51 and detected 0 issues on this pull request.

View more on Code Climate.

@github-actions
Copy link

Visit the preview URL for this PR (updated for commit 3d7cf51):

https://react-rainbow--pr2090-fix-recalculate-inte-vud71ik9.web.app

(expires Mon, 18 Jan 2021 04:58:51 GMT)

🔥 via Firebase Hosting GitHub Action 🌎

@LeandroTorresSicilia LeandroTorresSicilia merged commit ef04efd into master Jan 11, 2021
@LeandroTorresSicilia LeandroTorresSicilia deleted the fix-recalculate-internaloverlay-position branch January 11, 2021 18:18
jpetaux pushed a commit to jpetaux/react-rainbow that referenced this pull request Jun 27, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

fix: the tooltip has to recalculate the position when the internal content changes
2 participants