Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: fix application component issue in next.js #2101

Merged

Conversation

wildergd
Copy link
Collaborator

@wildergd wildergd commented Jan 16, 2021

#1471
fix: #2109
fix: #2108

Changes proposed in this PR:

  • fix issue in next.js when adding Application component

  • fix issue in next.js when adding FilseSelector component

  • I have followed (at least) the PR section of the contributing guide.

@nexxtway/react-rainbow

@wildergd wildergd added WIP work in progress Not ready labels Jan 16, 2021
@commit-lint
Copy link

commit-lint bot commented Jan 16, 2021

Bug Fixes

  • fix application component issue in next.js (a0f9fb4)
  • fix FileSelector componemt (c5cf494)
  • issues in comments (82d4891)
  • fix Application theme (8119573)
  • fix index.d.ts in ActivityTimeline (3aae8c6)

Contributors

wildergd

Commit-Lint commands

You can trigger Commit-Lint actions by commenting on this PR:

  • @Commit-Lint merge patch will merge dependabot PR on "patch" versions (X.X.Y - Y change)
  • @Commit-Lint merge minor will merge dependabot PR on "minor" versions (X.Y.Y - Y change)
  • @Commit-Lint merge major will merge dependabot PR on "major" versions (Y.Y.Y - Y change)
  • @Commit-Lint merge disable will desactivate merge dependabot PR
  • @Commit-Lint review will approve dependabot PR
  • @Commit-Lint stop review will stop approve dependabot PR

@github-actions
Copy link

github-actions bot commented Jan 16, 2021

Visit the preview URL for this PR (updated for commit 3aae8c6):

https://react-rainbow--pr2101-fix-application-comp-qz2z7rz8.web.app

(expires Tue, 26 Jan 2021 12:48:29 GMT)

🔥 via Firebase Hosting GitHub Action 🌎

@wildergd
Copy link
Collaborator Author

We have to check in FileSelector/index,d.ts, the line onChange? :(value: FileList) => void; i am not sure how to add the custom type

@codeclimate
Copy link

codeclimate bot commented Jan 19, 2021

Code Climate has analyzed commit 3aae8c6 and detected 0 issues on this pull request.

View more on Code Climate.

@LeandroTorresSicilia LeandroTorresSicilia merged commit 221a1fa into master Jan 19, 2021
@LeandroTorresSicilia LeandroTorresSicilia deleted the fix-application-component-error-in-nextjs branch January 19, 2021 16:49
jpetaux pushed a commit to jpetaux/react-rainbow that referenced this pull request Jun 27, 2021
* fix: fix application component issue in next.js

* fix: fix FileSelector componemt

* fix: issues in comments

* fix: fix Application theme

* fix: fix index.d.ts in ActivityTimeline
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

fix: getBrowserLocale function for support ssr fix: window.FileList on the FileSelector components
2 participants