Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: enhance code #2103

Merged
merged 4 commits into from
Jan 19, 2021
Merged

fix: enhance code #2103

merged 4 commits into from
Jan 19, 2021

Conversation

wildergd
Copy link
Collaborator

@wildergd wildergd commented Jan 17, 2021

fix: #2099

Changes proposed in this PR:

@nexxtway/react-rainbow

@commit-lint
Copy link

commit-lint bot commented Jan 17, 2021

Bug Fixes

Doc

Contributors

wildergd

Commit-Lint commands

You can trigger Commit-Lint actions by commenting on this PR:

  • @Commit-Lint merge patch will merge dependabot PR on "patch" versions (X.X.Y - Y change)
  • @Commit-Lint merge minor will merge dependabot PR on "minor" versions (X.Y.Y - Y change)
  • @Commit-Lint merge major will merge dependabot PR on "major" versions (Y.Y.Y - Y change)
  • @Commit-Lint merge disable will desactivate merge dependabot PR
  • @Commit-Lint review will approve dependabot PR
  • @Commit-Lint stop review will stop approve dependabot PR

@github-actions
Copy link

github-actions bot commented Jan 17, 2021

Visit the preview URL for this PR (updated for commit f84fe01):

https://react-rainbow--pr2103-fix-activitytimeline-r71ym9s1.web.app

(expires Mon, 25 Jan 2021 21:28:03 GMT)

🔥 via Firebase Hosting GitHub Action 🌎

@codeclimate
Copy link

codeclimate bot commented Jan 18, 2021

Code Climate has analyzed commit f84fe01 and detected 9 issues on this pull request.

Here's the issue category breakdown:

Category Count
Complexity 4
Duplication 5

View more on Code Climate.

@LeandroTorresSicilia LeandroTorresSicilia merged commit b1d8280 into master Jan 19, 2021
@LeandroTorresSicilia LeandroTorresSicilia deleted the fix-activitytimeline branch January 19, 2021 05:51
jpetaux pushed a commit to jpetaux/react-rainbow that referenced this pull request Jun 27, 2021
* fix: enhance code

* fix: issues in commnents

* fix: issues in comments

* doc: fix jsdoc
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

feat: improve ActivityTimeline and TimelineMarker components
2 participants