Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add inline variant to MarkdownOutput #2207

Merged
merged 6 commits into from
Apr 2, 2021

Conversation

HellWolf93
Copy link
Collaborator

Changes proposed in this PR:

@commit-lint
Copy link

commit-lint bot commented Mar 27, 2021

Features

  • add inline variant to MarkdownOutput (635e6e4)

Bug Fixes

Contributors

HellWolf93, LeandroTorresSicilia

Commit-Lint commands

You can trigger Commit-Lint actions by commenting on this PR:

  • @Commit-Lint merge patch will merge dependabot PR on "patch" versions (X.X.Y - Y change)
  • @Commit-Lint merge minor will merge dependabot PR on "minor" versions (X.Y.Y - Y change)
  • @Commit-Lint merge major will merge dependabot PR on "major" versions (Y.Y.Y - Y change)
  • @Commit-Lint merge disable will desactivate merge dependabot PR
  • @Commit-Lint review will approve dependabot PR
  • @Commit-Lint stop review will stop approve dependabot PR

);
};

export const defaultRenderer = {
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Similar blocks of code found in 2 locations. Consider refactoring.

@@ -46,3 +59,25 @@ export default {
td: StyledTableCell,
pre: StyledPre,
};

export const inlineRenderer = {
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Similar blocks of code found in 2 locations. Consider refactoring.

@@ -25,7 +30,15 @@ const Heading = ({ level, children }) => {
);
};

export default {
const InlineHeading = ({ level, children }) => {
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Similar blocks of code found in 2 locations. Consider refactoring.

@github-actions
Copy link

github-actions bot commented Mar 27, 2021

Visit the preview URL for this PR (updated for commit 85661b0):

https://react-rainbow--pr2207-add-inline-markdown-wd1yq29z.web.app

(expires Fri, 09 Apr 2021 14:24:07 GMT)

🔥 via Firebase Hosting GitHub Action 🌎

@codeclimate
Copy link

codeclimate bot commented Apr 2, 2021

Code Climate has analyzed commit 85661b0 and detected 6 issues on this pull request.

Here's the issue category breakdown:

Category Count
Duplication 6

View more on Code Climate.

@LeandroTorresSicilia LeandroTorresSicilia merged commit 064fc47 into master Apr 2, 2021
@LeandroTorresSicilia LeandroTorresSicilia deleted the add-inline-markdown branch April 2, 2021 14:30
jpetaux pushed a commit to jpetaux/react-rainbow that referenced this pull request Jun 27, 2021
* feat: add inline variant to MarkdownOutput

* fix: fix style typo

* fix: update tests

* fix: improve some styles

* fix: add inline variant to container

Co-authored-by: Jose Leandro Torres <jtorressicilia@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants