-
-
Notifications
You must be signed in to change notification settings - Fork 112
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add inline variant to MarkdownOutput #2207
Conversation
Features
Bug Fixes
ContributorsHellWolf93, LeandroTorresSicilia Commit-Lint commandsYou can trigger Commit-Lint actions by commenting on this PR:
|
); | ||
}; | ||
|
||
export const defaultRenderer = { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Similar blocks of code found in 2 locations. Consider refactoring.
@@ -46,3 +59,25 @@ export default { | |||
td: StyledTableCell, | |||
pre: StyledPre, | |||
}; | |||
|
|||
export const inlineRenderer = { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Similar blocks of code found in 2 locations. Consider refactoring.
@@ -25,7 +30,15 @@ const Heading = ({ level, children }) => { | |||
); | |||
}; | |||
|
|||
export default { | |||
const InlineHeading = ({ level, children }) => { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Similar blocks of code found in 2 locations. Consider refactoring.
Visit the preview URL for this PR (updated for commit 85661b0): https://react-rainbow--pr2207-add-inline-markdown-wd1yq29z.web.app (expires Fri, 09 Apr 2021 14:24:07 GMT) 🔥 via Firebase Hosting GitHub Action 🌎 |
Code Climate has analyzed commit 85661b0 and detected 6 issues on this pull request. Here's the issue category breakdown:
View more on Code Climate. |
* feat: add inline variant to MarkdownOutput * fix: fix style typo * fix: update tests * fix: improve some styles * fix: add inline variant to container Co-authored-by: Jose Leandro Torres <jtorressicilia@gmail.com>
Changes proposed in this PR:
Added inline variant to MarkdownOutput component
I have followed (at least) the PR section of the contributing guide.