feat: implement ShowIf component #2300
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Features
Tests
Documentation
Bug FixesContributorsCommit-Lint commandsYou can trigger Commit-Lint actions by commenting on this PR:
|
![codeclimate[bot]](https://avatars.githubusercontent.com/in/9403?s=60&v=4){kind=small}
| import ShowIf from '..'; | ||
|
|
||
| describe('<ShowIf />', () => { | ||
| it('should render the children in the DOM when isTrue is false', () => { |
There was a problem hiding this comment.
Similar blocks of code found in 2 locations. Consider refactoring.
|
Visit the preview URL for this PR (updated for commit c95ecf8): https://react-rainbow--pr2300-implement-showif-fv5p51hd.web.app (expires Thu, 28 Oct 2021 20:02:17 GMT) 🔥 via Firebase Hosting GitHub Action 🌎 |
LeandroTorresSicilia
approved these changes
Oct 13, 2021
src/components/ShowIf/index.d.ts
Outdated
| import { ReactNode } from 'react'; | ||
| import { BaseProps } from '../types'; | ||
|
|
||
| type AnimationName = 'fade' | 'slide'; |
There was a problem hiding this comment.
here we need to specify if the slide will be from right, left, top, bottom
we don't need to set all of them now, but what will be used them let's specify it
|
Code Climate has analyzed commit c95ecf8 and detected 2 issues on this pull request. Here's the issue category breakdown:
View more on Code Climate. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes proposed in this PR:
Added ShowIf component
I have followed (at least) the PR section of the contributing guide.