Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add the icon prop to DatePicker and DateTimePicker #2324

Merged
merged 5 commits into from
Dec 8, 2021

Conversation

HellWolf93
Copy link
Collaborator

fix: #2315

Changes proposed in this PR:

@commit-lint
Copy link

commit-lint bot commented Dec 3, 2021

Features

  • add the icon prop to DatePicker and DateTimePicker (2bd2fe5)

Bug Fixes

  • remove trailing whitespace (7dd159a)

Contributors

HellWolf93, LeandroTorresSicilia, TahimiLeonBravo

Commit-Lint commands

You can trigger Commit-Lint actions by commenting on this PR:

  • @Commit-Lint merge patch will merge dependabot PR on "patch" versions (X.X.Y - Y change)
  • @Commit-Lint merge minor will merge dependabot PR on "minor" versions (X.Y.Y - Y change)
  • @Commit-Lint merge major will merge dependabot PR on "major" versions (Y.Y.Y - Y change)
  • @Commit-Lint merge disable will desactivate merge dependabot PR
  • @Commit-Lint review will approve dependabot PR
  • @Commit-Lint stop review will stop approve dependabot PR

@codeclimate
Copy link

codeclimate bot commented Dec 7, 2021

Code Climate has analyzed commit 3075ae3 and detected 3 issues on this pull request.

Here's the issue category breakdown:

Category Count
Duplication 3

View more on Code Climate.

@github-actions
Copy link

github-actions bot commented Dec 7, 2021

Visit the preview URL for this PR (updated for commit 3075ae3):

https://react-rainbow--pr2324-add-datepicker-icon-64kxhc3x.web.app

(expires Tue, 14 Dec 2021 03:26:08 GMT)

🔥 via Firebase Hosting GitHub Action 🌎

@LeandroTorresSicilia LeandroTorresSicilia merged commit 6a0f087 into master Dec 8, 2021
@LeandroTorresSicilia LeandroTorresSicilia deleted the add-datepicker-icon branch December 8, 2021 13:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

feat: Allow replacing the DatePicker's icon through props.
3 participants