Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: refactor PhoneInput component #2333

Merged
merged 12 commits into from
Dec 15, 2021
Merged

Conversation

HellWolf93
Copy link
Collaborator

fix: #2327

Changes proposed in this PR:

@commit-lint
Copy link

commit-lint bot commented Dec 10, 2021

Wip

Features

  • use InternalOverlay in PhoneInput (8610f70)

Bug Fixes

  • improve PhoneInput focus handling (48331e9)
  • update hook parameters (07398e2)
  • dropdown on PhoneInput not closing sometimes (b3197e2)
  • close PhoneInput dropdown on resize (51b736c)
  • fix PhoneInput not changing country sometimes (8c5cefd)
  • send same value on change callback when country change (6898e69)
  • trigger ci (ff85a97)

Tests

  • fix failing test case on ZoomableImage component (122e95c)

Contributors

HellWolf93, LeandroTorresSicilia

Commit-Lint commands

You can trigger Commit-Lint actions by commenting on this PR:

  • @Commit-Lint merge patch will merge dependabot PR on "patch" versions (X.X.Y - Y change)
  • @Commit-Lint merge minor will merge dependabot PR on "minor" versions (X.Y.Y - Y change)
  • @Commit-Lint merge major will merge dependabot PR on "major" versions (Y.Y.Y - Y change)
  • @Commit-Lint merge disable will desactivate merge dependabot PR
  • @Commit-Lint review will approve dependabot PR
  • @Commit-Lint stop review will stop approve dependabot PR

@github-actions
Copy link

github-actions bot commented Dec 10, 2021

Visit the preview URL for this PR (updated for commit e7c6f50):

https://react-rainbow--pr2333-refactor-phoneinput-wek55dvg.web.app

(expires Wed, 22 Dec 2021 03:44:04 GMT)

🔥 via Firebase Hosting GitHub Action 🌎

@HellWolf93 HellWolf93 changed the title Refactor phoneinput fix: refactor PhoneInput component Dec 10, 2021
@LeandroTorresSicilia
Copy link
Member

Screen Shot 2021-12-11 at 11 47 29 AM

when change the country the onChange send a different object shape, this is the most important part of the component then we need to get this well tested

@codeclimate
Copy link

codeclimate bot commented Dec 15, 2021

Code Climate has analyzed commit ff85a97 and detected 13 issues on this pull request.

Here's the issue category breakdown:

Category Count
Duplication 13

View more on Code Climate.

@LeandroTorresSicilia LeandroTorresSicilia merged commit c4d58b4 into master Dec 15, 2021
@LeandroTorresSicilia LeandroTorresSicilia deleted the refactor-phoneinput branch December 15, 2021 03:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

phone input z-index issues
2 participants