feat: add type declarations to libs and styles #2435
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Features
Bug Fixes
ContributorsCommit-Lint commandsYou can trigger Commit-Lint actions by commenting on this PR:
|
|
Visit the preview URL for this PR (updated for commit e696093): https://react-rainbow--pr2435-add-libs-styles-type-alebnb6q.web.app (expires Mon, 01 Aug 2022 22:33:52 GMT) 馃敟 via Firebase Hosting GitHub Action 馃寧 |
src/libs/hooks/useDisclosure.d.ts
Outdated
| toggle: () => void; | ||
| } | ||
|
|
||
| declare function useDisclosure(defaultIsOpen: any): Disclosure; |
There was a problem hiding this comment.
we should not use any
src/libs/hooks/useDisclosure.d.ts
Outdated
| toggle: () => void; | ||
| } | ||
|
|
||
| declare function useDisclosure(defaultIsOpen: any): Disclosure; |
There was a problem hiding this comment.
also here defaultIsOpen should be optional
| @@ -0,0 +1,2 @@ | |||
| declare function useErrorMessageId(error: any): string | undefined; | |||
There was a problem hiding this comment.
same ^^ no any and optional
src/libs/hooks/useLabelId.d.ts
Outdated
| @@ -0,0 +1,2 @@ | |||
| declare function useLabelId(label: any): string | undefined; | |||
src/libs/hooks/useLocale.d.ts
Outdated
| @@ -0,0 +1,2 @@ | |||
| declare function useLocale(localProp: string): string; | |||
| @@ -0,0 +1,2 @@ | |||
| declare function useUniqueIdentifier(prefix: string): string; | |||
|
Code Climate has analyzed commit e606127 and detected 3 issues on this pull request. Here's the issue category breakdown:
View more on Code Climate. |
LeandroTorresSicilia
approved these changes
Jul 25, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.