Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: types in onSort prop of the table to be more strict #2455

Conversation

yvmunayev
Copy link
Contributor

fix: #2454

Changes proposed in this PR:

  • fix: types in onSort prop of the Table to be more strict (nextSortdirection must be the same as the prop sortDirection asc | desc)

  • I have followed (at least) the PR section of the contributing guide.

@nexxtway/react-rainbow

@commit-lint
Copy link

commit-lint bot commented Sep 25, 2022

Bug Fixes

  • types in onSort prop of the table to be more strict (baa3aa3)

Contributors

yvmunayev, LeandroTorresSicilia

Commit-Lint commands

You can trigger Commit-Lint actions by commenting on this PR:

  • @Commit-Lint merge patch will merge dependabot PR on "patch" versions (X.X.Y - Y change)
  • @Commit-Lint merge minor will merge dependabot PR on "minor" versions (X.Y.Y - Y change)
  • @Commit-Lint merge major will merge dependabot PR on "major" versions (Y.Y.Y - Y change)
  • @Commit-Lint merge disable will desactivate merge dependabot PR
  • @Commit-Lint review will approve dependabot PR
  • @Commit-Lint stop review will stop approve dependabot PR

@codeclimate
Copy link

codeclimate bot commented Sep 25, 2022

Code Climate has analyzed commit baa3aa3 and detected 0 issues on this pull request.

View more on Code Climate.

@LeandroTorresSicilia LeandroTorresSicilia merged commit 4466255 into master Sep 28, 2022
@LeandroTorresSicilia LeandroTorresSicilia deleted the fix-types-in-on-sort-prop-of-the-table-to-be-more-strict branch September 28, 2022 16:16
@github-actions
Copy link

Visit the preview URL for this PR (updated for commit 65fb05b):

https://react-rainbow--pr2455-fix-types-in-on-sort-brjpwhdt.web.app

(expires Wed, 05 Oct 2022 16:20:40 GMT)

🔥 via Firebase Hosting GitHub Action 🌎

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

fix: types in onSort prop of the Table to be more strict
2 participants