feat: add options declaration type to chart component #2459
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Features
Bug Fixes
Contributorsyvmunayev, LeandroTorresSicilia Commit-Lint commandsYou can trigger Commit-Lint actions by commenting on this PR:
|
src/components/Chart/index.d.ts
Outdated
| @@ -19,6 +20,8 @@ export interface ChartProps extends BaseProps { | |||
| maintainAspectRatio?: boolean; | |||
| plugins?: Array<object>; | |||
| children?: ReactNode; | |||
| options?: ChartOptions; | |||
| [key: string]: unknown; | |||
There was a problem hiding this comment.
I think here we only need to add options, the [key: string]: unknown; is only needed for dataset where you can pass extra props defined by plugins but here I don't think we need this
|
Visit the preview URL for this PR (updated for commit 37112b4): https://react-rainbow--pr2459-feat-add-options-dec-mziflasm.web.app (expires Sun, 09 Oct 2022 17:45:17 GMT) 🔥 via Firebase Hosting GitHub Action 🌎 |
LeandroTorresSicilia
approved these changes
Oct 2, 2022
|
Code Climate has analyzed commit 37112b4 and detected 0 issues on this pull request. View more on Code Climate. |
LeandroTorresSicilia
deleted the
feat-add-options-declaration-type-to-chart-component
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fix: #2458
Changes proposed in this PR:
feat: add options declaration type to chart component
I have followed (at least) the PR section of the contributing guide.
@nexxtway/react-rainbow