Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add border radius prop to button #2493

Merged
merged 2 commits into from Oct 20, 2022

Conversation

adrianestevez1
Copy link
Contributor

@adrianestevez1 adrianestevez1 commented Oct 20, 2022

fix: #2491

Changes proposed in this PR:

-add borderRadius prop to Button component

@nexxtway/react-rainbow

@commit-lint
Copy link

commit-lint bot commented Oct 20, 2022

Features

  • add borderRadius prop to Button component (97607d3)
  • add borderRadius prop to Button component (91056ab)
Commit-Lint commands

You can trigger Commit-Lint actions by commenting on this PR:

  • @Commit-Lint merge patch will merge dependabot PR on "patch" versions (X.X.Y - Y change)
  • @Commit-Lint merge minor will merge dependabot PR on "minor" versions (X.Y.Y - Y change)
  • @Commit-Lint merge major will merge dependabot PR on "major" versions (Y.Y.Y - Y change)
  • @Commit-Lint merge disable will desactivate merge dependabot PR
  • @Commit-Lint review will approve dependabot PR
  • @Commit-Lint stop review will stop approve dependabot PR

@CLAassistant
Copy link

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.


Adrian Estevez seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account.
You have signed the CLA already but the status is still pending? Let us recheck it.

@codeclimate
Copy link

codeclimate bot commented Oct 20, 2022

Code Climate has analyzed commit 91056ab and detected 2 issues on this pull request.

Here's the issue category breakdown:

Category Count
Duplication 2

View more on Code Climate.

@github-actions
Copy link

Visit the preview URL for this PR (updated for commit 91056ab):

https://react-rainbow--pr2493-add-border-radius-pr-ggehh2cf.web.app

(expires Thu, 27 Oct 2022 17:53:48 GMT)

🔥 via Firebase Hosting GitHub Action 🌎

Sign: 2de6d670498a0a515484c5637b13d0215372df83

@LeandroTorresSicilia LeandroTorresSicilia changed the title Add border radius prop feat: add border radius prop to button Oct 20, 2022
@LeandroTorresSicilia LeandroTorresSicilia merged commit 4361bcd into master Oct 20, 2022
@LeandroTorresSicilia LeandroTorresSicilia deleted the add-border-radius-prop branch October 20, 2022 18:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

feat: add borderRadius prop to Button component
3 participants