Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add border radius to inputable components #2504

Merged
merged 10 commits into from
Nov 2, 2022

Conversation

adrianestevez1
Copy link
Contributor

fix: #2499

Changes proposed in this PR:

  • Add borderRadius prop to the following components:
    ColorInput
    CounterInput
    DatePicker
    DateTimePicker
    GoogleAddressLookup
    Input
    Lookup
    PhoneInput
    Picklist
    Select
    StripeCardInput
    StrongPasswordInput
    Textarea
    TimePicker
    FileSelector
    CurrencyInput
    PercentInput
    MultiSelect

  • I have followed (at least) the PR section of the contributing guide.

@nexxtway/react-rainbow

@commit-lint
Copy link

commit-lint bot commented Oct 26, 2022

Bug Fixes

  • changing to functional components and converting to individual states in components with different border radius (6b08024)

Contributors

LeandroTorresSicilia

Commit-Lint commands

You can trigger Commit-Lint actions by commenting on this PR:

  • @Commit-Lint merge patch will merge dependabot PR on "patch" versions (X.X.Y - Y change)
  • @Commit-Lint merge minor will merge dependabot PR on "minor" versions (X.Y.Y - Y change)
  • @Commit-Lint merge major will merge dependabot PR on "major" versions (Y.Y.Y - Y change)
  • @Commit-Lint merge disable will desactivate merge dependabot PR
  • @Commit-Lint review will approve dependabot PR
  • @Commit-Lint stop review will stop approve dependabot PR

@CLAassistant
Copy link

CLAassistant commented Oct 26, 2022

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you all sign our Contributor License Agreement before we can accept your contribution.
1 out of 2 committers have signed the CLA.

✅ LeandroTorresSicilia
❌ Adrian Estevez


Adrian Estevez seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account.
You have signed the CLA already but the status is still pending? Let us recheck it.

@github-actions
Copy link

github-actions bot commented Oct 26, 2022

Visit the preview URL for this PR (updated for commit 6104e08):

https://react-rainbow--pr2504-add-border-radius-to-dlio9yzx.web.app

(expires Wed, 09 Nov 2022 05:26:43 GMT)

🔥 via Firebase Hosting GitHub Action 🌎

Sign: 2de6d670498a0a515484c5637b13d0215372df83

…tates in components with different border radius
@codeclimate
Copy link

codeclimate bot commented Nov 2, 2022

Code Climate has analyzed commit 6104e08 and detected 22 issues on this pull request.

Here's the issue category breakdown:

Category Count
Duplication 22

View more on Code Climate.

@LeandroTorresSicilia LeandroTorresSicilia merged commit 2a4acfc into master Nov 2, 2022
@LeandroTorresSicilia LeandroTorresSicilia deleted the add-border-radius-to-inputable branch November 2, 2022 06:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

feat: add borderRadius prop to inputable components
3 participants